Re: [PR] confirmation dialog box for DAG run actions [airflow]

["theaadya (via GitHub)" <gi...@apache.org>]

theaadya commented on code in PR #35393:
URL: https://github.com/apache/airflow/pull/35393#discussion_r1414319928


##########
airflow/www/static/js/dag/details/dagRun/MarkRunAs.tsx:
##########
@@ -58,42 +65,115 @@ const MarkRunAs = ({ runId, state, ...otherProps }: Props) => {
     markSuccess({ confirmed: true });
   };
 
+  useEffect(() => {
+    const storedSuccessValue = localStorage.getItem("doNotShowAgainSuccess");
+    const storedFailedValue = localStorage.getItem("doNotShowAgainFailed");

Review Comment:
   So does that mean neither of the Mark Run As dialog boxes (Success/Failed) should appear again on clicking the do not show again checkbox in any of the two?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org