You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "bbovenzi (via GitHub)" <gi...@apache.org> on 2023/02/03 15:57:00 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #29359: Remove /legacy_tree endpoint
bbovenzi opened a new pull request, #29359:
URL: https://github.com/apache/airflow/pull/29359
In https://github.com/apache/airflow/pull/20730, we accidentally create `/legacy_tree` endpoint. The redirect for tree should follow the other legacy redirects we made when we changed how /dag urls were structured.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a diff in pull request #29359: Remove /legacy_tree endpoint
Posted by "ryanahamilton (via GitHub)" <gi...@apache.org>.
ryanahamilton commented on code in PR #29359:
URL: https://github.com/apache/airflow/pull/29359#discussion_r1096005156
##########
airflow/www/views.py:
##########
@@ -2713,7 +2699,7 @@ def legacy_tree(self):
)
@gzipped
@action_logging
- def tree(self):
+ def legacy_tree(self):
Review Comment:
If `/legacy_tree` wasn't there before, wouldn't you want to keep the redirect from `/tree`?
```suggestion
def tree(self):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #29359: Remove /legacy_tree endpoint
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #29359:
URL: https://github.com/apache/airflow/pull/29359#discussion_r1096144527
##########
airflow/www/views.py:
##########
@@ -2713,7 +2699,7 @@ def legacy_tree(self):
)
@gzipped
@action_logging
- def tree(self):
+ def legacy_tree(self):
Review Comment:
We don't use `Airflow.tree` anywhere. This function name change was to be consistent with the other `legacy_*` redirects (graph, gantt, code, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on a diff in pull request #29359: Remove /legacy_tree endpoint
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #29359:
URL: https://github.com/apache/airflow/pull/29359#discussion_r1096144527
##########
airflow/www/views.py:
##########
@@ -2713,7 +2699,7 @@ def legacy_tree(self):
)
@gzipped
@action_logging
- def tree(self):
+ def legacy_tree(self):
Review Comment:
We don't use `Airflow.tree` anywhere. This was to be consistent with the other `legacy_*` redirects (graph, gantt, code, etc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29359: Remove /legacy_tree endpoint
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29359:
URL: https://github.com/apache/airflow/pull/29359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org