[jira] [Commented] (CASSANDRA-8582) Descriptor.fromFilename seems broken for BIG format

["Benjamin Lerer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270766#comment-14270766 ] 

Benjamin Lerer commented on CASSANDRA-8582:
-------------------------------------------

[~tjake] I do not really understand the 'Not a Problem' resolution.

>From the Descriptor class API, I would expect the following behavior:
{code}
Descriptor original = new Descriptor(tempDataDir, ksname, cfname, 1, Descriptor.Type.TEMP, SSTableFormat.Type.BIG);
String file = original.filenameFor(Component.DATA);
Descriptor clone = Descriptor.fromFilename(file );
assertEquals(clone, original);
{code}

This behavior used to be valid as it was used within {{SSTableSimpleUnsortedWriter}} and the change actually broke {{CQLSSTableWriter}}. Base on that I am a bit afraid that the change of behavior broke other part of the code too. 

> Descriptor.fromFilename seems broken for BIG format
> ---------------------------------------------------
>
>                 Key: CASSANDRA-8582
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8582
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benjamin Lerer
>            Assignee: T Jake Luciani
>
> The problem can be reproduced in {{DescriptorTest}} by adding the following unit test:
> {code}
>     @Test
>     public void testFromFileNameWithBIGFormat()
>     {
>         checkFromFilename(new Descriptor(tempDataDir, ksname, cfname, 1, Descriptor.Type.TEMP, SSTableFormat.Type.BIG), false);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)