You are viewing a plain text version of this content. The canonical link for it is here.
Posted to torque-dev@db.apache.org by gm...@apache.org on 2007/10/19 00:06:42 UTC
svn commit: r586154 -
/db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java
Author: gmonroe
Date: Thu Oct 18 15:06:41 2007
New Revision: 586154
URL: http://svn.apache.org/viewvc?rev=586154&view=rev
Log:
Fix for a problem that occurs when the query criteria has an offset defined but no record limit. Sybase/MSSQL DBs will now pass the testOffsetLimit test case.
Modified:
db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java
Modified: db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java
URL: http://svn.apache.org/viewvc/db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java?rev=586154&r1=586153&r2=586154&view=diff
==============================================================================
--- db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java (original)
+++ db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java Thu Oct 18 15:06:41 2007
@@ -166,6 +166,9 @@
public void generateLimits(Query query, int offset, int limit)
throws TorqueException
{
+ if ( limit < 0 && offset >= 0 ) { // Offset only test
+ return;
+ }
if (limit + offset > 0)
{
query.setRowcount(String.valueOf(limit + offset));
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org
Re: svn commit: r586154 - /db/torque/runtime/trunk/src/java/org/apache/torque/adapter/DBSybase.java
Posted by Scott Eade <se...@backstagetech.com.au>.
gmonroe@apache.org wrote:
> + if ( limit < 0 && offset >= 0 ) { // Offset only test
> + return;
> + }
>
Just a nit pick. Following our coding standard this should be:
if (limit < 0 && offset >= 0) // Offset only test
{
return;
}
i.e. no spaces within the if brackets and the open brace on a new line.
Scott
---------------------------------------------------------------------
To unsubscribe, e-mail: torque-dev-unsubscribe@db.apache.org
For additional commands, e-mail: torque-dev-help@db.apache.org