You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Yifan Xing (Jira)" <ji...@apache.org> on 2019/10/09 17:22:00 UTC
[jira] [Commented] (SPARK-28859) Remove value check of
MEMORY_OFFHEAP_SIZE in declaration section
[ https://issues.apache.org/jira/browse/SPARK-28859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947865#comment-16947865 ]
Yifan Xing commented on SPARK-28859:
------------------------------------
Looks like this is done? If you check [resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala|https://github.com/apache/spark/pull/25309/files#diff-f8659513cf91c15097428c3d8dfbcc35]
`executorOffHeapMemorySizeAsMb` function has the following code on line 192-193.
{{require(sizeInMB > 0,}}
{{ s"${MEMORY_OFFHEAP_SIZE.key} must be > 0 when ${MEMORY_OFFHEAP_ENABLED.key} == true")}}
> Remove value check of MEMORY_OFFHEAP_SIZE in declaration section
> ----------------------------------------------------------------
>
> Key: SPARK-28859
> URL: https://issues.apache.org/jira/browse/SPARK-28859
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 3.0.0
> Reporter: Yang Jie
> Priority: Minor
>
> Now MEMORY_OFFHEAP_SIZE has default value 0, but It should be greater than 0 when
> MEMORY_OFFHEAP_ENABLED is true,, should we check this condition in code?
>
> SPARK-28577 add this check before request memory resource to Yarn
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org