[GitHub] [hadoop] melissayou commented on a diff in pull request #5067: HADOOP-17612. Upgrade Zookeeper to 3.6.3 and Curator to 5.2.0

[GitBox <gi...@apache.org>]

melissayou commented on code in PR #5067:
URL: https://github.com/apache/hadoop/pull/5067#discussion_r1008446843


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/test/java/org/apache/hadoop/hdfs/server/federation/security/token/TestZKDelegationTokenSecretManagerImpl.java:
##########
@@ -162,6 +162,7 @@ public void testMultiNodeTokenRemovalShortSyncWithoutWatch()
 
   // This is very unlikely to happen in real case, but worth putting
   // the case out
+  @SuppressWarnings("unchecked")

Review Comment:
   Yes it was added by me to fix failed javac problem reported in earlier [builds](https://github.com/apache/hadoop/pull/5067#issuecomment-1292262434). There're two similar places(line135&201) and either will fail javac. 
   
   So two ways:
   1. Keep it in sync with trunk and let javac fail for this PR. 
   2.(What I did here) fix it by adding suppress warning here as I'm pretty confident those types are correct. This test file is consistent - you can see the untouched method testMultiNodeOperationWithoutWatch() has the exact same problem and has suppress warning. So I think it's applicable to the other two methods as well. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org