You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by ijuma <gi...@git.apache.org> on 2016/06/18 23:43:47 UTC

[GitHub] kafka pull request #1522: KAFKA-3866; KerberosLogin refresh time bug and oth...

GitHub user ijuma opened a pull request:

    https://github.com/apache/kafka/pull/1522

    KAFKA-3866; KerberosLogin refresh time bug and other improvements

    * Handle correctly the case where the refresh is supposed to happen now
    * Replace `now + minTimeBeforeLogin` with `lastLogin + minTimeBeforeLogin`
    * Break from loop if there are no retries left after `reLogin` fails
    * `reLogin` no longer checks if sufficient time has elapsed as the check
    is done elsewhere when appropriate and it would incorrectly not relogin
    even if that meant that the ticket would expire
    * Removed duplicate logic in `getRefreshTime` regarding a refresh time
    that was greater than the expiry time
    * Comment and logging clean-ups
    * Add validators for a few SASL configs

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijuma/kafka kafka-3866-kerberos-login-refresh-time-bug

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1522.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1522
    
----
commit c75633a5134ca98be2427ea5dfb4a97b2706828a
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-06-18T23:42:26Z

    Various fixes and improvements to KerberosLogin
    
    * Handle correctly the case where the refresh is supposed to happen now
    * Replace `now + minTimeBeforeLogin` with `lastLogin + minTimeBeforeLogin`
    * Break from loop if there are no retries left after `reLogin` fails
    * `reLogin` no longer checks if sufficient time has elapsed as the check
    is done elsewhere when appropriate and it would incorrectly not relogin
    even if that meant that the ticket would expire
    * Removed duplicate logic in `getRefreshTime` regarding a refresh time
    that was greater than the expiry time
    * Comment and logging clean-ups

commit bbddd5a654159f4c006b1c91207a76c0ed700b99
Author: Ismael Juma <is...@juma.me.uk>
Date:   2016-06-18T23:42:53Z

    Add validators for a few SASL configs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---