You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bridges-user@portals.apache.org by Steve Bosman <st...@gmail.com> on 2009/06/23 13:49:09 UTC
How can I set WindowState in Struts bridge based portlet links?
Hi,
Since this list is fairly low traffic, I've also asked this question on
stackoverflow ( http://stackoverflow.com/questions/1031622 ).
I am developing a JSR-286 compliant portlet based on struts 1.2.9 (for
historical reasons we want to reuse a lot existing code) using the struts
portlet bridge. I want some links to change the WindowState, but the FormTag
and LinkTag provided by the portal bridge don't have an easy way to set the
WindowState. I'm happy to extend these two tags, but am unsure how to
proceed.
How can I determine what request parameters need adding in a portal agnostic
way? For instance, it would appear that liferay uses p_p_state and
gridsphere gs_state.
Steve
--
http://www.stevebosman.co.uk/
"I hear and I forget. I see and I remember. I do and I understand." -
Confucius
Re: How can I set WindowState in Struts bridge based portlet links?
Posted by Ate Douma <at...@douma.nu>.
Steve Bosman wrote:
> On Thu, Jun 25, 2009 at 10:51 AM, Ate Douma <at...@douma.nu> wrote:
>> The entry is just fine, thanks.
>
> Good :)
>
>> I've already assigned it to myself andd will try to look at it shortly as
> soon as I can make some time free for this.
>> As I also mentioned in the issue, it might be useful to add setting
> portletMode as well which would merge very easily with your patch.
>
> Yes, I agree that is a good idea. I'll have a look and see what is involved.
>
>> I have another question: as you mentioned in your initial email, you are
> using String 1.2.9.
>> When we're going to release a new version of the String Bridge, I'll have
> to decide which target struts 1.x version(s) to support.
>> The current bridge is still targeted at Struts 1.2.7.
>> Can you elaborate why you are using Struts 1.2.9 and for example not using
> a 1.3.x version (yet)?
>> There might be technical/migration issues I need to consider but I haven't
> investigated this.
>> Any input you have might be very helpful to me.
>
> I'm currently in the research phase for a portlet project at work. We
> already have a fairly large struts 1.1 project which, due to some custom
> extensions, people have always been a little scared of migrating. I've
> implemented changes to migrate to 1.2.9, but there are quite a few
> deprecated methods/classes in 1.2.9 that are used in our main code base that
> have been removed in 1.3 and I didn't want to attempt the migration just yet
> - partially because it looks like a lot of work to do on a research branch
> and partially because the struts bridge is targeted at 1.2.7.
>
> We settled on the struts bridge early on and initially I was using 1.2.7
> (since that is the supported version), but liferay ships with 1.2.9 so I
> moved to that version.
Ok, thanks for the information.
Looks like we'll have to (keep) supporting 1.2.x too then (which I'm fine doing).
I'll try to investigate if there are 1.3.x changes which might affect the struts bridge itself, although AFAIK its not depending on any
deprecated methods.
Did you need to make other changed/enhancements for the Struts Bridge like the Struts tld mapping for 1.2.9?
If so, I'd be interested in those as well to incorporate it in the next version.
As another off-topic question which you might willing to answer: is there any technical of functional reason you are using Liferay and not
(for example) Jetspeed-2?
Regards,
Ate
>
> Steve
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-user-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-user-help@portals.apache.org
Re: How can I set WindowState in Struts bridge based portlet links?
Posted by Steve Bosman <st...@gmail.com>.
On Thu, Jun 25, 2009 at 10:51 AM, Ate Douma <at...@douma.nu> wrote:
>
> The entry is just fine, thanks.
Good :)
>
> I've already assigned it to myself andd will try to look at it shortly as
soon as I can make some time free for this.
> As I also mentioned in the issue, it might be useful to add setting
portletMode as well which would merge very easily with your patch.
Yes, I agree that is a good idea. I'll have a look and see what is involved.
>
> I have another question: as you mentioned in your initial email, you are
using String 1.2.9.
> When we're going to release a new version of the String Bridge, I'll have
to decide which target struts 1.x version(s) to support.
> The current bridge is still targeted at Struts 1.2.7.
> Can you elaborate why you are using Struts 1.2.9 and for example not using
a 1.3.x version (yet)?
>
> There might be technical/migration issues I need to consider but I haven't
investigated this.
> Any input you have might be very helpful to me.
I'm currently in the research phase for a portlet project at work. We
already have a fairly large struts 1.1 project which, due to some custom
extensions, people have always been a little scared of migrating. I've
implemented changes to migrate to 1.2.9, but there are quite a few
deprecated methods/classes in 1.2.9 that are used in our main code base that
have been removed in 1.3 and I didn't want to attempt the migration just yet
- partially because it looks like a lot of work to do on a research branch
and partially because the struts bridge is targeted at 1.2.7.
We settled on the struts bridge early on and initially I was using 1.2.7
(since that is the supported version), but liferay ships with 1.2.9 so I
moved to that version.
Steve
Re: How can I set WindowState in Struts bridge based portlet links?
Posted by Ate Douma <at...@douma.nu>.
Steve Bosman wrote:
> On Thu, Jun 25, 2009 at 8:19 AM, Ate Douma <at...@douma.nu> wrote:
>
>> Hi Steve,
>>
>> I see you already answered your own question on stackoverflow :)
>> Your solution is fine and if you are willing to create a new JIRA issue for
>> it at http://issues.apache.org/jira/browse/PB with a patch attached, I'm
>> happy to incorporate this in the next version of the Struts Bridge.
>>
>> Regards,
>>
>> Ate
>>
>
> I've raised an issue ( https://issues.apache.org/jira/browse/PB-91 ) and
> submitted the patch - I wasn't that sure about how to fill in the fields, so
> I'm sorry if I made any mistakes (let me know and I'll try to better in the
> future).
The entry is just fine, thanks.
I've already assigned it to myself andd will try to look at it shortly as soon as I can make some time free for this.
As I also mentioned in the issue, it might be useful to add setting portletMode as well which would merge very easily with your patch.
I have another question: as you mentioned in your initial email, you are using String 1.2.9.
When we're going to release a new version of the String Bridge, I'll have to decide which target struts 1.x version(s) to support.
The current bridge is still targeted at Struts 1.2.7.
Can you elaborate why you are using Struts 1.2.9 and for example not using a 1.3.x version (yet)?
There might be technical/migration issues I need to consider but I haven't investigated this.
Any input you have might be very helpful to me.
Thanks,
Ate
>
> Steve
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-user-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-user-help@portals.apache.org
Re: How can I set WindowState in Struts bridge based portlet links?
Posted by Steve Bosman <st...@gmail.com>.
On Thu, Jun 25, 2009 at 8:19 AM, Ate Douma <at...@douma.nu> wrote:
> Hi Steve,
>
> I see you already answered your own question on stackoverflow :)
> Your solution is fine and if you are willing to create a new JIRA issue for
> it at http://issues.apache.org/jira/browse/PB with a patch attached, I'm
> happy to incorporate this in the next version of the Struts Bridge.
>
> Regards,
>
> Ate
>
I've raised an issue ( https://issues.apache.org/jira/browse/PB-91 ) and
submitted the patch - I wasn't that sure about how to fill in the fields, so
I'm sorry if I made any mistakes (let me know and I'll try to better in the
future).
Steve
Re: How can I set WindowState in Struts bridge based portlet links?
Posted by Ate Douma <at...@douma.nu>.
Hi Steve,
I see you already answered your own question on stackoverflow :)
Your solution is fine and if you are willing to create a new JIRA issue for it at http://issues.apache.org/jira/browse/PB with a patch
attached, I'm happy to incorporate this in the next version of the Struts Bridge.
Regards,
Ate
Steve Bosman wrote:
> Hi,
> Since this list is fairly low traffic, I've also asked this question on
> stackoverflow ( http://stackoverflow.com/questions/1031622 ).
>
> I am developing a JSR-286 compliant portlet based on struts 1.2.9 (for
> historical reasons we want to reuse a lot existing code) using the struts
> portlet bridge. I want some links to change the WindowState, but the FormTag
> and LinkTag provided by the portal bridge don't have an easy way to set the
> WindowState. I'm happy to extend these two tags, but am unsure how to
> proceed.
>
> How can I determine what request parameters need adding in a portal agnostic
> way? For instance, it would appear that liferay uses p_p_state and
> gridsphere gs_state.
>
> Steve
>
---------------------------------------------------------------------
To unsubscribe, e-mail: bridges-user-unsubscribe@portals.apache.org
For additional commands, e-mail: bridges-user-help@portals.apache.org