You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/12/04 14:21:17 UTC
[GitHub] [hadoop] bgaborg edited a comment on issue #1691: HADOOP-16424.
S3Guard fsck: Check internal consistency of the MetadataStore
bgaborg edited a comment on issue #1691: HADOOP-16424. S3Guard fsck: Check internal consistency of the MetadataStore
URL: https://github.com/apache/hadoop/pull/1691#issuecomment-561666553
> One question though: what should we be doing in this specific case? As I believe it is a sign that this entry was created from an older version of S3Guard. So it's not really an error -more a sign that we need to fix it somehow.
We need to use severity.
> The exit code on the failure was 0; if we do consider it to be an error then we should return an error code to indicate an inconsistency was detected.
Fixed.
> Looking in the code, I can see that it's a severity level "2", so not that serious.
>
> 1. We should go away from and int value here to something comprehensible, i.e. an enum.
> 2. Or at least some contents used in the Violation enum setup.
> 3. Either way, how about letting us choose which level to fail on.
> 4. And maybe severity 2 should be logged at WARN, not ERROR, as I was confused "why an error yet none reported in status"
>
> I know that these are not directly related to this patch, but I think it will help the usability. I think we should address this as a follow-up?
created: https://issues.apache.org/jira/browse/HADOOP-16745
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org