[jira] [Commented] (OODT-427) filemgr query throws "String index out of range: -1" when some products have undefined metadata values

["jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OODT-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235978#comment-13235978 ] 

jiraposter@reviews.apache.org commented on OODT-427:
----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4451/
-----------------------------------------------------------

Review request for Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John, and Thomas Bennett.


Summary
-------

Cleaned up metadata to string methods of QueryResult. If metadata was empty, it was trying to delete a trailing comma that doesn't exist.


This addresses bug OODT-427.
    https://issues.apache.org/jira/browse/OODT-427


Diffs
-----

  trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResult.java 1303205 
  trunk/filemgr/src/test/org/apache/oodt/cas/filemgr/cli/action/TestSqlQueryCliAction.java 1303205 

Diff: https://reviews.apache.org/r/4451/diff


Testing
-------

Added unit test to check for empty metadata.

Changed existing unit test to account for implementation-dependent ordering of keys.


Thanks,

Ricky


                
> filemgr query throws "String index out of range: -1" when some products have undefined metadata values
> ------------------------------------------------------------------------------------------------------
>
>                 Key: OODT-427
>                 URL: https://issues.apache.org/jira/browse/OODT-427
>             Project: OODT
>          Issue Type: Bug
>          Components: file manager
>    Affects Versions: 0.3
>            Reporter: Ricky Nguyen
>             Fix For: 0.4
>
>
> To reproduce:
> 1) ingest a ProductType without metadata (except ProductType defined)
> 2) run a sql query without output format
> 3) String index out of bounds thrown as shown below
> [vpicu@palmer bin]$ ./filemgr-client -u $FILEMGR_URL -op -sql -q 'SELECT EpisodeStartTime FROM Events'
> Mar 22, 2012 12:17:54 PM org.apache.oodt.cas.filemgr.system.XmlRpcFileManagerClient <init>
> INFO: Loading File Manager Configuration Properties from: [../etc/filemgr.properties]
> ERROR: Failed to perform sql query : sortBy 'null', outputFormat 'null', and delimiter '
> ', filterAlgor 'null', startDateTimeMetKey 'null', endDateTimeMetKey 'null', priorityMetKey 'null', null' : String index out of range: -1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira