[GitHub] [incubator-druid] gianm opened a new pull request #8889: Tidy up lifecycle, query, and ingestion logging.

[GitBox <gi...@apache.org>]

gianm opened a new pull request #8889: Tidy up lifecycle, query, and ingestion logging.
URL: https://github.com/apache/incubator-druid/pull/8889
 
 
   The goal of this patch is to improve the clarity and usefulness of
   Druid's logging for cluster operators. For more information, see
   https://twitter.com/cowtowncoder/status/1195469299814555648.
   
   Concretely, this patch does the following:
   
   - Changes a lot of INFO logs to DEBUG, and DEBUG to TRACE, with the
     goal of reducing redundancy and improving clarity by avoiding
     showing rarely-useful log messages. This includes most "starting"
     and "stopping" messages, and most messages related to individual
     columns.
   - Adds new log4j2 templates that show operators how to enabled DEBUG
     logging for certain important packages.
   - Eliminate stack traces for query errors, unless log level is DEBUG
     or more. This is useful because query errors often indicate user
     error rather than system error, but dumping stack trace often gave
     operators the impression that there was a system failure.
   - Adds task id to Appenderator, AppenderatorDriver thread names. In
     the default log4j2 configuration, this will put them in log lines
     as well. It's very useful if a user is using the Indexer, where
     multiple tasks run in the same JVM.
   - More consistent terminology when it comes to "sequences" (sets of
     segments that are handed-off together by Kafka ingestion) and
     "offsets" (cursors in partitions). These terms had been confused in
     some log messages due to the fact that Kinesis calls offsets
     "sequence numbers".
   - Replaces some ugly toString calls with either the JSONification or
     something more operator-accessible (like a URL or segment identifier,
     instead of JSON object representing the same).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org