You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lenya.apache.org by eg...@apache.org on 2004/01/07 14:22:42 UTC
cvs commit: cocoon-lenya/src/java/org/apache/lenya/cms/publication SiteTreeNodeImpl.java
egli 2004/01/07 05:22:42
Modified: src/java/org/apache/lenya/cms/publication
SiteTreeNodeImpl.java
Log:
Added a fixme about simplyfying the boolean expression that is used in
getLabel. This can be simpyfied since the language of a label should
now never be null.
Revision Changes Path
1.22 +7 -4 cocoon-lenya/src/java/org/apache/lenya/cms/publication/SiteTreeNodeImpl.java
Index: SiteTreeNodeImpl.java
===================================================================
RCS file: /home/cvs/cocoon-lenya/src/java/org/apache/lenya/cms/publication/SiteTreeNodeImpl.java,v
retrieving revision 1.21
retrieving revision 1.22
diff -u -r1.21 -r1.22
--- SiteTreeNodeImpl.java 23 Sep 2003 13:46:02 -0000 1.21
+++ SiteTreeNodeImpl.java 7 Jan 2004 13:22:42 -0000 1.22
@@ -206,7 +206,10 @@
for (int i = 0; i < labels.length; i++) {
language = labels[i].getLanguage();
-
+
+ // FIXME: This expression is too complicated
+ // considering there can no longer be any labels with
+ // a null language, i.e. each label must have a language.
if ((((xmlLanguage == null) || (xmlLanguage.equals(""))) && (language == null))
|| ((language != null) && (language.equals(xmlLanguage)))) {
label = labels[i];
---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-cvs-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-cvs-help@cocoon.apache.org