You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2026/08/25 16:45:09 UTC
[PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
adoroszlai opened a new pull request, #11117:
URL: https://github.com/apache/ozone/pull/11117
## What changes were proposed in this pull request?
- Make `TestLocalChunkInputStream` extend `InpuStreamTests` instead of `TestChunkInputStream`
- Parameterize `TestChunkInputStream` to also test with short-circuit read enabled
- Keep only `testFallbackToGrpc` in `TestLocalChunkInputStream`
- Remove unnecessary cluster creation from `TestStreamBlockInputStream`
https://issues.apache.org/jira/browse/HDDS-16100
## How was this patch tested?
Without native lib:
```
Tests run: 2, Failures: 0, Errors: 0, Skipped: 2, Time elapsed: 0.037 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 19.91 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 37.15 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 64.82 s -- in org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.063 s -- in org.apache.hadoop.ozone.client.rpc.read.TestLocalChunkInputStream
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.97 s -- in org.apache.hadoop.ozone.client.rpc.read.TestStreamBlockInputStream
```
With native lib:
```
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 21.79 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.90 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 0, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 55.68 s -- in org.apache.hadoop.ozone.client.rpc.read.TestChunkInputStream
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 87.33 s -- in org.apache.hadoop.ozone.client.rpc.read.TestKeyInputStream
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.89 s -- in org.apache.hadoop.ozone.client.rpc.read.TestLocalChunkInputStream
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 92.17 s -- in org.apache.hadoop.ozone.client.rpc.read.TestStreamBlockInputStream
```
https://github.com/adoroszlai/ozone/actions/runs/32855529592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #11117:
URL: https://github.com/apache/ozone/pull/11117#discussion_r3861495548
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/InputStreamTests.java:
##########
@@ -83,6 +92,8 @@ protected MiniOzoneCluster newCluster() throws Exception {
.setStreamBufferMaxSize(MAX_FLUSH_SIZE)
.applyTo(conf);
+ enableShortCircuitRead(dir, conf);
Review Comment:
Thanks, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11117:
URL: https://github.com/apache/ozone/pull/11117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #11117:
URL: https://github.com/apache/ozone/pull/11117#discussion_r3861392138
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/TestChunkInputStream.java:
##########
@@ -17,44 +17,111 @@
package org.apache.hadoop.ozone.client.rpc.read;
+import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.ONE;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
import java.io.IOException;
import java.nio.ByteBuffer;
import org.apache.commons.io.IOUtils;
+import org.apache.hadoop.hdds.client.RatisReplicationConfig;
+import org.apache.hadoop.hdds.client.ReplicationConfig;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.scm.XceiverClientGrpc;
+import org.apache.hadoop.hdds.scm.XceiverClientShortCircuit;
import org.apache.hadoop.hdds.scm.storage.BlockInputStream;
import org.apache.hadoop.hdds.scm.storage.ChunkInputStream;
+import org.apache.hadoop.hdds.scm.storage.DomainSocketFactory;
+import org.apache.hadoop.hdds.scm.storage.LocalChunkInputStream;
import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
import org.apache.hadoop.ozone.client.io.KeyInputStream;
import org.apache.hadoop.ozone.container.common.impl.ContainerLayoutVersion;
import org.apache.hadoop.ozone.container.keyvalue.ContainerLayoutTestInfo;
import org.apache.hadoop.ozone.om.BucketForTesting;
+import org.apache.ozone.test.GenericTestUtils.LogCapturer;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.params.Parameter;
+import org.junit.jupiter.params.ParameterizedClass;
+import org.junit.jupiter.params.provider.ValueSource;
/**
* Tests {@link ChunkInputStream}.
*/
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@ParameterizedClass
+@ValueSource(booleans = {true, false})
class TestChunkInputStream extends InputStreamTests {
+ @Parameter
+ private boolean useShortCircuitRead;
+
+ private LogCapturer localChunkInputStreamLog;
+ private LogCapturer shortCircuitClientLog;
+ private LogCapturer blockInputStreamLog;
+ private LogCapturer grpcClientLog;
+
+ @BeforeEach
+ void startCapturing() {
+ localChunkInputStreamLog = LogCapturer.captureLogs(LocalChunkInputStream.LOG);
+ shortCircuitClientLog = LogCapturer.captureLogs(XceiverClientShortCircuit.LOG);
+ blockInputStreamLog = LogCapturer.captureLogs(BlockInputStream.LOG);
+ grpcClientLog = LogCapturer.captureLogs(XceiverClientGrpc.LOG);
+ }
+
+ @AfterEach
+ void stopCapturing() {
+ org.apache.hadoop.hdds.utils.IOUtils.closeQuietly(
+ blockInputStreamLog, grpcClientLog, localChunkInputStreamLog, shortCircuitClientLog);
+ }
+
+ @Override
+ int getDatanodeCount() {
+ return getRepConfig().getRequiredNodes();
+ }
+
+ @Override
+ ReplicationConfig getRepConfig() {
+ return RatisReplicationConfig.getInstance(ONE);
+ }
+
/**
* Run the tests as a single test method to avoid needing a new mini-cluster
* for each test.
*/
@ContainerLayoutTestInfo.ContainerTest
void testAll(ContainerLayoutVersion layout) throws Exception {
- try (OzoneClient client = getCluster().newClient()) {
- updateConfig(layout);
+ if (useShortCircuitRead) {
+ assumeTrue(DomainSocketFactory.getInstance(getCluster().getConf()).isServiceReady());
+ }
+ updateConfig(layout);
+
+ OzoneConfiguration clientConfig = new OzoneConfiguration(getCluster().getConf());
+ useShortCircuitRead(clientConfig, useShortCircuitRead);
+ debugShortCircuitRead();
+
+ try (OzoneClient client = OzoneClientFactory.getRpcClient(clientConfig)) {
BucketForTesting bucket = BucketForTesting.newBuilder(client).build();
testChunkReadBuffers(bucket);
testBufferRelease(bucket);
testCloseReleasesBuffers(bucket);
}
+
+ assertEquals(useShortCircuitRead, localChunkInputStreamLog.getOutput()
Review Comment:
We would have to mirror the statements for the two cases, so I prefer `assertEquals` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #11117:
URL: https://github.com/apache/ozone/pull/11117#discussion_r3861203723
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/InputStreamTests.java:
##########
@@ -83,6 +92,8 @@ protected MiniOzoneCluster newCluster() throws Exception {
.setStreamBufferMaxSize(MAX_FLUSH_SIZE)
.applyTo(conf);
+ enableShortCircuitRead(dir, conf);
Review Comment:
Could we keep short-circuit setup opt-in for `TestChunkInputStream` and `TestLocalChunkInputStream`? Enabling it in the shared `InputStreamTests` setup also changes `TestKeyInputStream` and `TestStreamBlockInputStream` to use `LocalChunkInputStream` when the native library is available, so their existing gRPC coverage is lost.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/TestChunkInputStream.java:
##########
@@ -17,44 +17,111 @@
package org.apache.hadoop.ozone.client.rpc.read;
+import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.ONE;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
import java.io.IOException;
import java.nio.ByteBuffer;
import org.apache.commons.io.IOUtils;
+import org.apache.hadoop.hdds.client.RatisReplicationConfig;
+import org.apache.hadoop.hdds.client.ReplicationConfig;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.scm.XceiverClientGrpc;
+import org.apache.hadoop.hdds.scm.XceiverClientShortCircuit;
import org.apache.hadoop.hdds.scm.storage.BlockInputStream;
import org.apache.hadoop.hdds.scm.storage.ChunkInputStream;
+import org.apache.hadoop.hdds.scm.storage.DomainSocketFactory;
+import org.apache.hadoop.hdds.scm.storage.LocalChunkInputStream;
import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
import org.apache.hadoop.ozone.client.io.KeyInputStream;
import org.apache.hadoop.ozone.container.common.impl.ContainerLayoutVersion;
import org.apache.hadoop.ozone.container.keyvalue.ContainerLayoutTestInfo;
import org.apache.hadoop.ozone.om.BucketForTesting;
+import org.apache.ozone.test.GenericTestUtils.LogCapturer;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.params.Parameter;
+import org.junit.jupiter.params.ParameterizedClass;
+import org.junit.jupiter.params.provider.ValueSource;
/**
* Tests {@link ChunkInputStream}.
*/
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@ParameterizedClass
+@ValueSource(booleans = {true, false})
class TestChunkInputStream extends InputStreamTests {
+ @Parameter
+ private boolean useShortCircuitRead;
+
+ private LogCapturer localChunkInputStreamLog;
+ private LogCapturer shortCircuitClientLog;
+ private LogCapturer blockInputStreamLog;
+ private LogCapturer grpcClientLog;
+
+ @BeforeEach
+ void startCapturing() {
+ localChunkInputStreamLog = LogCapturer.captureLogs(LocalChunkInputStream.LOG);
+ shortCircuitClientLog = LogCapturer.captureLogs(XceiverClientShortCircuit.LOG);
+ blockInputStreamLog = LogCapturer.captureLogs(BlockInputStream.LOG);
+ grpcClientLog = LogCapturer.captureLogs(XceiverClientGrpc.LOG);
+ }
+
+ @AfterEach
+ void stopCapturing() {
+ org.apache.hadoop.hdds.utils.IOUtils.closeQuietly(
+ blockInputStreamLog, grpcClientLog, localChunkInputStreamLog, shortCircuitClientLog);
+ }
+
+ @Override
+ int getDatanodeCount() {
+ return getRepConfig().getRequiredNodes();
+ }
+
+ @Override
+ ReplicationConfig getRepConfig() {
+ return RatisReplicationConfig.getInstance(ONE);
+ }
+
/**
* Run the tests as a single test method to avoid needing a new mini-cluster
* for each test.
*/
@ContainerLayoutTestInfo.ContainerTest
void testAll(ContainerLayoutVersion layout) throws Exception {
- try (OzoneClient client = getCluster().newClient()) {
- updateConfig(layout);
+ if (useShortCircuitRead) {
+ assumeTrue(DomainSocketFactory.getInstance(getCluster().getConf()).isServiceReady());
+ }
+ updateConfig(layout);
+
+ OzoneConfiguration clientConfig = new OzoneConfiguration(getCluster().getConf());
+ useShortCircuitRead(clientConfig, useShortCircuitRead);
+ debugShortCircuitRead();
+
+ try (OzoneClient client = OzoneClientFactory.getRpcClient(clientConfig)) {
BucketForTesting bucket = BucketForTesting.newBuilder(client).build();
testChunkReadBuffers(bucket);
testBufferRelease(bucket);
testCloseReleasesBuffers(bucket);
}
+
+ assertEquals(useShortCircuitRead, localChunkInputStreamLog.getOutput()
Review Comment:
nit: Could we use AssertJ `contains` / `doesNotContain` here? This would make a failure show which log content selected the wrong client path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on code in PR #11117:
URL: https://github.com/apache/ozone/pull/11117#discussion_r3861484483
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/client/rpc/read/TestChunkInputStream.java:
##########
@@ -17,44 +17,111 @@
package org.apache.hadoop.ozone.client.rpc.read;
+import static org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.ONE;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertNull;
+import static org.junit.jupiter.api.Assumptions.assumeTrue;
import java.io.IOException;
import java.nio.ByteBuffer;
import org.apache.commons.io.IOUtils;
+import org.apache.hadoop.hdds.client.RatisReplicationConfig;
+import org.apache.hadoop.hdds.client.ReplicationConfig;
+import org.apache.hadoop.hdds.conf.OzoneConfiguration;
+import org.apache.hadoop.hdds.scm.XceiverClientGrpc;
+import org.apache.hadoop.hdds.scm.XceiverClientShortCircuit;
import org.apache.hadoop.hdds.scm.storage.BlockInputStream;
import org.apache.hadoop.hdds.scm.storage.ChunkInputStream;
+import org.apache.hadoop.hdds.scm.storage.DomainSocketFactory;
+import org.apache.hadoop.hdds.scm.storage.LocalChunkInputStream;
import org.apache.hadoop.ozone.client.OzoneClient;
+import org.apache.hadoop.ozone.client.OzoneClientFactory;
import org.apache.hadoop.ozone.client.io.KeyInputStream;
import org.apache.hadoop.ozone.container.common.impl.ContainerLayoutVersion;
import org.apache.hadoop.ozone.container.keyvalue.ContainerLayoutTestInfo;
import org.apache.hadoop.ozone.om.BucketForTesting;
+import org.apache.ozone.test.GenericTestUtils.LogCapturer;
+import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.TestInstance;
+import org.junit.jupiter.params.Parameter;
+import org.junit.jupiter.params.ParameterizedClass;
+import org.junit.jupiter.params.provider.ValueSource;
/**
* Tests {@link ChunkInputStream}.
*/
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
+@ParameterizedClass
+@ValueSource(booleans = {true, false})
class TestChunkInputStream extends InputStreamTests {
+ @Parameter
+ private boolean useShortCircuitRead;
+
+ private LogCapturer localChunkInputStreamLog;
+ private LogCapturer shortCircuitClientLog;
+ private LogCapturer blockInputStreamLog;
+ private LogCapturer grpcClientLog;
+
+ @BeforeEach
+ void startCapturing() {
+ localChunkInputStreamLog = LogCapturer.captureLogs(LocalChunkInputStream.LOG);
+ shortCircuitClientLog = LogCapturer.captureLogs(XceiverClientShortCircuit.LOG);
+ blockInputStreamLog = LogCapturer.captureLogs(BlockInputStream.LOG);
+ grpcClientLog = LogCapturer.captureLogs(XceiverClientGrpc.LOG);
+ }
+
+ @AfterEach
+ void stopCapturing() {
+ org.apache.hadoop.hdds.utils.IOUtils.closeQuietly(
+ blockInputStreamLog, grpcClientLog, localChunkInputStreamLog, shortCircuitClientLog);
+ }
+
+ @Override
+ int getDatanodeCount() {
+ return getRepConfig().getRequiredNodes();
+ }
+
+ @Override
+ ReplicationConfig getRepConfig() {
+ return RatisReplicationConfig.getInstance(ONE);
+ }
+
/**
* Run the tests as a single test method to avoid needing a new mini-cluster
* for each test.
*/
@ContainerLayoutTestInfo.ContainerTest
void testAll(ContainerLayoutVersion layout) throws Exception {
- try (OzoneClient client = getCluster().newClient()) {
- updateConfig(layout);
+ if (useShortCircuitRead) {
+ assumeTrue(DomainSocketFactory.getInstance(getCluster().getConf()).isServiceReady());
+ }
+ updateConfig(layout);
+
+ OzoneConfiguration clientConfig = new OzoneConfiguration(getCluster().getConf());
+ useShortCircuitRead(clientConfig, useShortCircuitRead);
+ debugShortCircuitRead();
+
+ try (OzoneClient client = OzoneClientFactory.getRpcClient(clientConfig)) {
BucketForTesting bucket = BucketForTesting.newBuilder(client).build();
testChunkReadBuffers(bucket);
testBufferRelease(bucket);
testCloseReleasesBuffers(bucket);
}
+
+ assertEquals(useShortCircuitRead, localChunkInputStreamLog.getOutput()
Review Comment:
ok , got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "rich7420 (via GitHub)" <gi...@apache.org>.
rich7420 commented on PR #11117:
URL: https://github.com/apache/ozone/pull/11117#issuecomment-5423052078
@adoroszlai thanks for the patch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11117:
URL: https://github.com/apache/ozone/pull/11117#issuecomment-5436689174
@ChenSammi please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-16100. Parameterize TestChunkInputStream [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11117:
URL: https://github.com/apache/ozone/pull/11117#issuecomment-5449030722
Thanks @rich7420, @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org