You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Laszlo Hornyak <la...@gmail.com> on 2013/08/29 14:17:17 UTC

Review Request 13897: simplified casting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13897/
-----------------------------------------------------------

Review request for cloudstack and Min Chen.


Repository: cloudstack-git


Description
-------

double values do not need a Double object to be casted to long


Diffs
-----

  server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 7f16974 

Diff: https://reviews.apache.org/r/13897/diff/


Testing
-------


Thanks,

Laszlo Hornyak


Re: Review Request 13897: simplified casting

Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13897/#review26046
-----------------------------------------------------------


committed to 4.2-forward and master.

- Min Chen


On Aug. 29, 2013, 12:17 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13897/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 12:17 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> double values do not need a Double object to be casted to long
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 7f16974 
> 
> Diff: https://reviews.apache.org/r/13897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Re: Review Request 13897: simplified casting

Posted by Min Chen <mi...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13897/#review26045
-----------------------------------------------------------

Ship it!


Ship It!

- Min Chen


On Aug. 29, 2013, 12:17 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13897/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 12:17 p.m.)
> 
> 
> Review request for cloudstack and Min Chen.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> double values do not need a Double object to be casted to long
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/api/query/dao/UserVmJoinDaoImpl.java 7f16974 
> 
> Diff: https://reviews.apache.org/r/13897/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>