You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2019/12/23 19:53:27 UTC

[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1115: [HUDI-392] Introduce DIstributedTestDataSource to generate test data

n3nash commented on a change in pull request #1115: [HUDI-392] Introduce DIstributedTestDataSource to generate test data
URL: https://github.com/apache/incubator-hudi/pull/1115#discussion_r360987666
 
 

 ##########
 File path: hudi-test-suite/src/main/java/org/apache/hudi/testsuite/generator/DeltaGenerator.java
 ##########
 @@ -108,6 +114,17 @@ public DeltaGenerator(DeltaConfig deltaOutputConfig, JavaSparkContext jsc, Spark
     return inputBatch;
   }
 
+  public JavaRDD<GenericRecord> generateUpsertsWithDistributedSource(Config operation) {
 
 Review comment:
   @yanghua Yes, we should refactor those parts. 
   
   For (5), what I mean is that when we perform distributedTestDataSource.fetchNext(Option.empty(), 10000000) does it return a bunch of updates + inserts (or just inserts) ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services