[GitHub] [kafka] see-quick commented on a diff in pull request #14211: MINOR: Add a few test cases to clients

["see-quick (via GitHub)" <gi...@apache.org>]

see-quick commented on code in PR #14211:
URL: https://github.com/apache/kafka/pull/14211#discussion_r1301012979


##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -2399,4 +2400,39 @@ public KafkaProducer<T, T> newKafkaProducer() {
         }
     }
 
+    @Test
+    void testSerializerMustNoBeANull() {

Review Comment:
   Such test case checks this constructor
   ```java
   public KafkaProducer(Properties properties) {
           this(properties, null, null);
       }
   ```
   but not (so hypothetically if someone change such constructor in the future this could cause problems)
   ```java
   public KafkaProducer(final Map<String, Object> configs) {
           this(configs, null, null);
       }
   ```
   I mean I can remove it if you think that this does not make sense :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org