You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/04/16 14:55:30 UTC
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/1899
[FLINK-3770] [gelly] Fix TriangleEnumerator performance
Implement optimization of ordering edges by degree and a JoinHint for the joining of edges and vertices.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 3770_fix_triangleenumerator_performance
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1899.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1899
----
commit 75403a672ffd2ffda842f56073f643d4b61a33e5
Author: Greg Hogan <co...@greghogan.com>
Date: 2016-04-16T10:04:07Z
[FLINK-3770] [gelly] Fix TriangleEnumerator performance
Implement optimization of ordering edges by degree and a JoinHint for
the joining of edges and vertices.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1899
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1899#issuecomment-211355794
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1899#issuecomment-211354538
Thanks for this PR! Apart from a minor comment, it looks good to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1899#discussion_r60047518
--- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/library/TriangleEnumeratorITCase.java ---
@@ -47,10 +47,11 @@ public void testTriangleEnumerator() throws Exception {
env);
List<Tuple3<Long,Long,Long>> actualOutput = graph.run(new TriangleEnumerator<Long, NullValue, NullValue>()).collect();
- List<Tuple3<Long,Long,Long>> expectedResult = TriangleCountData.getListOfTriangles();
+ List<Tuple3<Long,Long,Long>> expectedResult = TriangleCountData.getListOfTriangles();
- Assert.assertEquals(actualOutput.size(), expectedResult.size());
+ Assert.assertEquals(expectedResult.size(), actualOutput.size());
for(Tuple3<Long,Long,Long> resultTriangle:actualOutput) {
+ System.out.println(resultTriangle);
--- End diff --
Do we need to print the result? We try to avoid printing from tests unless it's absolutely necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on a diff in the pull request:
https://github.com/apache/flink/pull/1899#discussion_r60054841
--- Diff: flink-libraries/flink-gelly-examples/src/test/java/org/apache/flink/graph/library/TriangleEnumeratorITCase.java ---
@@ -47,10 +47,11 @@ public void testTriangleEnumerator() throws Exception {
env);
List<Tuple3<Long,Long,Long>> actualOutput = graph.run(new TriangleEnumerator<Long, NullValue, NullValue>()).collect();
- List<Tuple3<Long,Long,Long>> expectedResult = TriangleCountData.getListOfTriangles();
+ List<Tuple3<Long,Long,Long>> expectedResult = TriangleCountData.getListOfTriangles();
- Assert.assertEquals(actualOutput.size(), expectedResult.size());
+ Assert.assertEquals(expectedResult.size(), actualOutput.size());
for(Tuple3<Long,Long,Long> resultTriangle:actualOutput) {
+ System.out.println(resultTriangle);
--- End diff --
Yes, that was leftover from debugging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3770] [gelly] Fix TriangleEnumerator pe...
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the pull request:
https://github.com/apache/flink/pull/1899#issuecomment-211376216
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---