You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by paulgallagher75 <gi...@git.apache.org> on 2016/10/10 11:43:08 UTC
[GitHub] activemq-artemis pull request #833: Change netty version to 4.1.5.Final
GitHub user paulgallagher75 opened a pull request:
https://github.com/apache/activemq-artemis/pull/833
Change netty version to 4.1.5.Final
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulgallagher75/activemq-artemis change-netty-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #833
----
commit 8032af54debe7cf22291755ae62f6493a07b675f
Author: Paul Gallagher <pg...@redhat.com>
Date: 2016-10-10T11:35:25Z
ARTEMIS-779 upgrade to netty 4.1.5.Final
commit d8f7757b920b370a9eb21b3376c68508630c42ac
Author: Paul Gallagher <pg...@redhat.com>
Date: 2016-10-10T11:35:39Z
Merge branch 'master' of https://github.com/apache/activemq-artemis into change-netty-version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #833: Change netty version to 4.1.5.Final
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/833
@tabish121 I should have listened to you more Careful. ArtemisFeatureTest is failing because of this. I thought it passed but I looked it wrongly.
It's ok thought.. at least we know where is the failure and how to fix it.
@tabish121 / @paulgallagher75 how to fix it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #833: Change netty version to 4.1.5.Final
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/833#discussion_r82606612
--- Diff: artemis-protocols/artemis-mqtt-protocol/pom.xml ---
@@ -47,29 +47,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-codec-mqtt</artifactId>
+ <artifactId>netty-all</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
</dependencies>
- <build>
--- End diff --
I guess if tests are ok, we will be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #833: Change netty version to 4.1.5.Final
Posted by paulgallagher75 <gi...@git.apache.org>.
Github user paulgallagher75 commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/833#discussion_r82630526
--- Diff: artemis-protocols/artemis-mqtt-protocol/pom.xml ---
@@ -47,29 +47,12 @@
</dependency>
<dependency>
<groupId>io.netty</groupId>
- <artifactId>netty-codec-mqtt</artifactId>
+ <artifactId>netty-all</artifactId>
</dependency>
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
</dependencies>
- <build>
--- End diff --
MQTT Example worked fine, netty 4.1.5.Final is in the lib directory of the distro.
Netty 5 is no longer a dependency and the mqtt codec part is no long bundled into the mqtt protocol as the netty-all from 4.1.5.Final will satisfy the dep
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #833: Change netty version to 4.1.5.Final
Posted by gemmellr <gi...@git.apache.org>.
Github user gemmellr commented on the issue:
https://github.com/apache/activemq-artemis/pull/833
Reverting the replacement of netty-codec-mqtt with netty-all (but keeping the version change) might work, as the individual netty-foo modules do have OSGi metadata, and that would be a closer equivalent to what was being done previously.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #833: Change netty version to 4.1.5.Final
Posted by tabish121 <gi...@git.apache.org>.
Github user tabish121 commented on the issue:
https://github.com/apache/activemq-artemis/pull/833
Netty All doesn't include OSGi bundle info in case that is relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #833: Change netty version to 4.1.5.Final
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/833
@paulgallagher75 it still didn't work actually... I will ask @dejanb 's help :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #833: Change netty version to 4.1.5.Final
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/833
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #833: Change netty version to 4.1.5.Final
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/833
@paulgallagher75 can you do that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---