You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Joshua Watkins (JIRA)" <ji...@apache.org> on 2011/03/31 13:39:05 UTC
[jira] [Created] (CAMEL-3823) Upgrade to CometD 2.1.0
Upgrade to CometD 2.1.0
-----------------------
Key: CAMEL-3823
URL: https://issues.apache.org/jira/browse/CAMEL-3823
Project: Camel
Issue Type: Task
Affects Versions: 2.6.0
Reporter: Joshua Watkins
Priority: Minor
The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3823:
-------------------------------
Component/s: camel-cometd
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022082#comment-13022082 ]
Claus Ibsen commented on CAMEL-3823:
------------------------------------
I have fixed the TODO with the @deprecated api from Jetty
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022080#comment-13022080 ]
Claus Ibsen commented on CAMEL-3823:
------------------------------------
Ciaran
Thanks a lot of the patch. I have applied it to trunk.
It would be nice if you could add logging in the consumer side, when the push method is invoked. Just as you have on the producer side, at TRACE level.
Also I added a TODO in the component source code to upgrade to use the non deprecated API from Jetty. You are welcome to look into that as well.
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Ciaran Wood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ciaran Wood updated CAMEL-3823:
-------------------------------
Attachment: Adding_support_for_cometd_2_1_0.patch
Attached is a patch to upgrade the camel-cometd component to use cometd 2.1.0. I have tested applying the patch to trunk and it applies cleanly.
A quick note on some behaviour that has changed between cometd versions:
Before, any client could subscribe to /service/** channels and receive all publishes to that channel, regardless of whether they published the message. The behaviour in the new version is that /service/** channels work in a request-reply style. You subscribe to the channel, publish to that channel and only the publisher should receive a reply. This works quite well with the InOut pattern in camel, so in the CometdConsumer, we check the exchange pattern and if it is InOut, send a reply.
The previous InteractiveMain tests used to subscribe on /service/test, I have changed that to subscribe to /channel/test, which exhibits the older behaviour. I have added an InOut test which uses the /service/test channel.
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen resolved CAMEL-3823.
--------------------------------
Resolution: Fixed
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3823:
-------------------------------
Fix Version/s: Future
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Joshua Watkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13016782#comment-13016782 ]
Joshua Watkins commented on CAMEL-3823:
---------------------------------------
I will look into creating a patch.
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020812#comment-13020812 ]
Claus Ibsen commented on CAMEL-3823:
------------------------------------
Joshua any update on the patch?
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13014983#comment-13014983 ]
Claus Ibsen commented on CAMEL-3823:
------------------------------------
We love contributions so you are welcome to work on a patch with the upgrade.
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen reassigned CAMEL-3823:
----------------------------------
Assignee: Claus Ibsen
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: Future
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022717#comment-13022717 ]
Claus Ibsen commented on CAMEL-3823:
------------------------------------
Ciaran do you mind taking a look at CAMEL-1242? Maybe you changes already fixed that issue?
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-3823:
-------------------------------
Fix Version/s: (was: Future)
2.8.0
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Components: camel-cometd
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Assignee: Claus Ibsen
> Priority: Minor
> Fix For: 2.8.0
>
> Attachments: Adding_support_for_cometd_2_1_0.patch
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CAMEL-3823) Upgrade to CometD 2.1.0
Posted by "Joshua Watkins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CAMEL-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021004#comment-13021004 ]
Joshua Watkins commented on CAMEL-3823:
---------------------------------------
Another committer asked me if I had started creating the patch yet and if not they would commit the patch. At that time I hadn't. I will re-loop with him to see if he is close to submitting a patch. Otherwise I will finish shortly.
> Upgrade to CometD 2.1.0
> -----------------------
>
> Key: CAMEL-3823
> URL: https://issues.apache.org/jira/browse/CAMEL-3823
> Project: Camel
> Issue Type: Task
> Affects Versions: 2.6.0
> Reporter: Joshua Watkins
> Priority: Minor
> Fix For: Future
>
>
> The current version of the Cometd component uses Cometd 1.0.1. Cometd 2.1.0 has better support for the InOut messaging pattern.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira