You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/08/10 19:33:24 UTC
Review Request 61570: Added the `kill()` function to the containerizer
interface.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This would be used by now on for killing a container by sending
a signal to it similar to the linux equivalent `kill()` system call.
Diffs
-----
src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
Diff: https://reviews.apache.org/r/61570/diff/1/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review183103
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 2463 (patched)
<https://reviews.apache.org/r/61570/#comment259105>
I don't like this semantics. The signal here can be any signal, not necessarily a SIGKILL/SIGTERM. For instance, SIGUSR1, SIGALARM, etc., which might not be terminal signal.
Any reason why we want to destroy the container here?
- Jie Yu
On Aug. 14, 2017, 11:09 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 11:09 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
> src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/61570/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182988
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 14, 2017, 11:09 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 11:09 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
> src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/61570/diff/3/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 11:09 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Review comments
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This would be used by now on for killing a container by sending
a signal to it similar to the linux equivalent `kill()` system call.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
Diff: https://reviews.apache.org/r/61570/diff/3/
Changes: https://reviews.apache.org/r/61570/diff/2-3/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182898
-----------------------------------------------------------
src/slave/containerizer/containerizer.hpp
Lines 149 (patched)
<https://reviews.apache.org/r/61570/#comment258838>
I see you followed the `attach` pattern here, but another option is to make this pure virtual and explicitly implement kill (returns unsupported failure) on docker containerizer. An advantate I see that you can look at docker containerizer and quickly see what are the things you need to implement in the future.
- Vinod Kone
On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 5:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
> src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/61570/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182883
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp
Lines 582 (patched)
<https://reviews.apache.org/r/61570/#comment258821>
s/status/signal/
src/slave/containerizer/mesos/containerizer.cpp
Lines 587 (patched)
<https://reviews.apache.org/r/61570/#comment258822>
s/status/signal/
src/slave/containerizer/mesos/containerizer.cpp
Lines 2455 (patched)
<https://reviews.apache.org/r/61570/#comment258828>
Can you add a TODO to chain this on the launch completion future? Seems a bit unfortunate to destroy the container irrespective of the signal.
src/slave/containerizer/mesos/containerizer.cpp
Lines 2466 (patched)
<https://reviews.apache.org/r/61570/#comment258830>
s/running//
src/slave/containerizer/mesos/containerizer.cpp
Lines 2467 (patched)
<https://reviews.apache.org/r/61570/#comment258829>
no need to include the container id because the caller knows it already.
- Vinod Kone
On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 5:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
> src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/61570/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/#review182879
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61570/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 5:20 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Bugs: MESOS-7879
> https://issues.apache.org/jira/browse/MESOS-7879
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This would be used by now on for killing a container by sending
> a signal to it similar to the linux equivalent `kill()` system call.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
> src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
> src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
>
>
> Diff: https://reviews.apache.org/r/61570/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 61570: Added the `kill()` function to the
containerizer interface.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61570/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 5:20 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Bugs: MESOS-7879
https://issues.apache.org/jira/browse/MESOS-7879
Repository: mesos
Description
-------
This would be used by now on for killing a container by sending
a signal to it similar to the linux equivalent `kill()` system call.
Diffs (updated)
-----
src/slave/containerizer/containerizer.hpp 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c
src/slave/containerizer/mesos/containerizer.hpp fd586306f7a6d3d2cdb58481f0ef4906de8d0f88
src/slave/containerizer/mesos/containerizer.cpp ff192bb085f3554ad1b1f20fb73bf827bf04ef13
Diff: https://reviews.apache.org/r/61570/diff/2/
Changes: https://reviews.apache.org/r/61570/diff/1-2/
Testing
-------
make check
Thanks,
Anand Mazumdar