[GitHub] [cloudstack] shwstppr commented on a change in pull request #5028: Removed download icon when ISO is not extractable for users

[GitBox <gi...@apache.org>]

shwstppr commented on a change in pull request #5028:
URL: https://github.com/apache/cloudstack/pull/5028#discussion_r634190181



##########
File path: ui/src/config/section/image.js
##########
@@ -268,7 +268,7 @@ export default {
           dataView: true,
           show: (record, store) => {
             return (['Admin'].includes(store.userInfo.roletype) || // If admin or owner or belongs to current project
-              (record.domainid === store.userInfo.domainid && record.account === store.userInfo.account) ||
+              (record.domainid === store.userInfo.domainid && record.account === store.userInfo.account && record.isextractable) ||
               (record.domainid === store.userInfo.domainid && record.projectid && store.project && store.project.id && record.projectid === store.project.id)) &&
               !(record.account === 'system' && record.domainid === 1) &&
               record.isready

Review comment:
       @Spaceman1984 shouldn't `isextractable` condition be added with `isready` irrespective of same account or not?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org