[GitHub] [sling-org-apache-sling-feature-cpconverter] anchela commented on pull request #114: SLING-10770 - add node type support for sling initial content

[GitBox <gi...@apache.org>]

anchela commented on pull request #114:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/114#issuecomment-940957800


   @niekraaijmakers , just noticed that there was a test failing (but not the one you created afaik): 
   
   ```
   [ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.343 s <<< FAILURE! - in org.apache.sling.feature.cpconverter.handlers.BundleEntryHandleSlingInitialContentTest
   [ERROR] org.apache.sling.feature.cpconverter.handlers.BundleEntryHandleSlingInitialContentTest.testSlingInitialContent  Time elapsed: 0.092 s  <<< ERROR!
   java.io.IOException: Can not convert SLING-INF/app-root/components/global/include/mediaFormatSelection.json to enhanced DocView format
   	at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.extractSlingInitialContent(BundleEntryHandler.java:303)
   	at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.extractSlingInitialContent(BundleEntryHandler.java:247)
   	at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.processBundleInputStream(BundleEntryHandler.java:191)
   	at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandler.handle(BundleEntryHandler.java:179)
   	at org.apache.sling.feature.cpconverter.handlers.BundleEntryHandleSlingInitialContentTest.testSlingInitialContent(BundleEntryHandleSlingInitialContentTest.java:83)
   ```
   do you happen to know what causes this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org