[jira] [Commented] (CONNECTORS-1693) Add non-emptiness clause to realm check of Solr output connector

["Markus Schuch (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CONNECTORS-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17476647#comment-17476647 ] 

Markus Schuch commented on CONNECTORS-1693:
-------------------------------------------

I can confirm, that {{realm}} is "" instead of {{null}} when no basic auth realm is entered in the solr output connectors configuration form.
The patch lgtm!

>  Add non-emptiness clause to realm check of Solr output connector
> -----------------------------------------------------------------
>
>                 Key: CONNECTORS-1693
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-1693
>             Project: ManifoldCF
>          Issue Type: Bug
>    Affects Versions: ManifoldCF 2.21
>            Reporter: Markus Schuch
>            Assignee: Markus Schuch
>            Priority: Major
>             Fix For: ManifoldCF next
>
>         Attachments: 112.patch
>
>
> See external issue URL:
> {quote}The underlying HTTP client of the Solr output connector always configures a dedicated AuthScope of the connection, even if the provided realm is the empty string (""). This is due to the fact that the attribute realm is never null, but "" in case the user did not supply a parameter for this. This breaks connectivity in case basic authentication is in-place, but no realm is required. Thus, in both cases (null value and "" for realm) the HTTP client should use AuthScope.ANY. This commit adds the necessary non-emptiness clause to the realm check in order to fix this behavior.{quote}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)