[jira] [Commented] (FLINK-5740) Make WrappingFunction an interface and move to flink-core

["Aljoscha Krettek (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996506#comment-15996506 ] 

Aljoscha Krettek commented on FLINK-5740:
-----------------------------------------

Demoted from blocker for 1.3 because the tests in question where already unblocked another way. Also, properly implementing it this short before the release does not seem wise and the issue is actually more complicated than it looks. (I tried for a bit and ran into problems, especially with wrapping functions that override a part of the RichFunction methods but not all of them.)

> Make WrappingFunction an interface and move to flink-core
> ---------------------------------------------------------
>
>                 Key: FLINK-5740
>                 URL: https://issues.apache.org/jira/browse/FLINK-5740
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Aljoscha Krettek
>            Assignee: Tzu-Li (Gordon) Tai
>
> Making it an interface and having an {{AbstractWrappingFunction}} will allow implementations to have different classes as base classes. Also, we should change {{FunctionUtils}} to work like {{StreamingFunctionUtils}} so that wrapping functions don't have to implement the methods of {{RichFunction}}.
> These tests are disabled for now because we cannot properly implement the required features:
>  - WindowFoldITCase.testFoldWithProcessWindowFunction() (Scala)
>  - WindowFunctionITCase.testRichProcessWindowFunction() (Scala)
>  - WindowReduceITCase.testReduceWithProcessWindowFunction (Scala)
> Because of the ignored tests I'm updating to "blocker".



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)