(rocketmq-dashboard) branch rocketmq-studio updated: refactor(message): drop the unreachable message-track fallback (#4854)

[li...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

lizhimins pushed a commit to branch rocketmq-studio
in repository https://gitbox.apache.org/repos/asf/rocketmq-dashboard.git


The following commit(s) were added to refs/heads/rocketmq-studio by this push:
     new b6af2096a refactor(message): drop the unreachable message-track fallback (#4854)
b6af2096a is described below

commit b6af2096a804b52ee88e9914acfe665b44ba79b0
Author: Wang1rrr <15...@users.noreply.github.com>
AuthorDate: Thu Sep 24 10:46:17 2026 +0800

    refactor(message): drop the unreachable message-track fallback (#4854)
    
    `fallbackConsumerStatus` has had no caller since the commit that added it (#798), and `mapTrackType` was called only from inside it — the trace path builds consumer status from parsed trace records instead. The dead mapping was also wrong: `TrackType` has seven members in rocketmq-tools 5.5.0 and UNKNOWN is the only one reaching `default`, where it became `DeliveryStatus.failed`, yet `messageTrackDetail` sets UNKNOWN as the initial value on every group's MessageTrack before querying t [...]
---
 .../provider/apache/RocketMQMessageProvider.java   | 41 ----------------------
 1 file changed, 41 deletions(-)

diff --git a/server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java b/server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java
index 3405d1ce2..1f3e276eb 100644
--- a/server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java
+++ b/server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQMessageProvider.java
@@ -47,8 +47,6 @@ import org.apache.rocketmq.studio.instance.message.QueueOffsetVO;
 import org.apache.rocketmq.studio.instance.message.TraceNodeVO;
 import org.apache.rocketmq.studio.instance.message.TraceRecordVO;
 import org.apache.rocketmq.tools.admin.DefaultMQAdminExt;
-import org.apache.rocketmq.tools.admin.api.MessageTrack;
-import org.apache.rocketmq.tools.admin.api.TrackType;
 import org.springframework.context.annotation.Primary;
 import org.springframework.stereotype.Service;
 import org.springframework.util.StringUtils;
@@ -860,45 +858,6 @@ public class RocketMQMessageProvider implements MessageProvider {
                 .build();
     }
 
-    private List<ConsumerStatusVO> fallbackConsumerStatus(DefaultMQAdminExt adminExt, MessageExt message) {
-        List<ConsumerStatusVO> result = new ArrayList<>();
-        try {
-            List<MessageTrack> tracks = adminExt.messageTrackDetail(message);
-            if (tracks == null) {
-                return result;
-            }
-            for (MessageTrack track : tracks) {
-                result.add(ConsumerStatusVO.builder()
-                        .group(track.getConsumerGroup())
-                        .deliveryStatus(mapTrackType(track.getTrackType()))
-                        .consumeTime(0L)
-                        .retryCount(0)
-                        .build());
-            }
-        } catch (Exception e) {
-            log.warn("messageTrackDetail fallback failed for msgId={}: {}", message.getMsgId(), e.getMessage());
-        }
-        return result;
-    }
-
-    private DeliveryStatus mapTrackType(TrackType trackType) {
-        if (trackType == null) {
-            return DeliveryStatus.pending;
-        }
-        switch (trackType) {
-            case CONSUMED:
-            case CONSUME_BROADCASTING:
-            case CONSUMED_BUT_FILTERED:
-                return DeliveryStatus.success;
-            case NOT_CONSUME_YET:
-            case PULL:
-            case NOT_ONLINE:
-                return DeliveryStatus.pending;
-            default:
-                return DeliveryStatus.failed;
-        }
-    }
-
     MessageRecordVO toRecordVO(MessageExt messageExt) {
         return toRecordVO(messageExt, null);
     }