You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/10 05:49:14 UTC

[GitHub] [incubator-gobblin] sv2000 opened a new pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

sv2000 opened a new pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035


   
   This reverts commit 2305c26cd5813dbae88b4922fecc6d6737c460d9.
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1127
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   This option allows GobblinTaskRunner to "fail-fast" on metric reporting instantiation failures. This is particularly sseful in scenarios where pipeline monitoring depends on metrics and tracking events being emitted.
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Unit tests
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083


   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1) Report
   > Merging [#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.07%`.
   > The diff coverage is `53.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3035      +/-   ##
   ============================================
   + Coverage     45.66%   45.74%   +0.07%     
   - Complexity     9296     9328      +32     
   ============================================
     Files          1956     1960       +4     
     Lines         74397    74487      +90     
     Branches       8247     8257      +10     
   ============================================
   + Hits          33977    34077     +100     
   + Misses        37242    37232      -10     
     Partials       3178     3178              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `7.04% <0.00%> (-0.10%)` | `9.00 <0.00> (ø)` | |
   | [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `2.70% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `15.20% <0.00%> (-0.21%)` | `4.00 <0.00> (ø)` | |
   | [...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTWV0cmljUmVwb3J0ZXJFeGNlcHRpb24uamF2YQ==) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `33.03% <53.19%> (+14.22%)` | `30.00 <6.00> (+15.00)` | |
   | [...pache/gobblin/runtime/mapreduce/MRJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL01SSm9iTGF1bmNoZXIuamF2YQ==) | `53.45% <68.75%> (+0.40%)` | `19.00 <0.00> (ø)` | |
   | [...blin/runtime/services/MetricsReportingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc2VydmljZXMvTWV0cmljc1JlcG9ydGluZ1NlcnZpY2UuamF2YQ==) | `85.71% <71.42%> (-14.29%)` | `5.00 <3.00> (+2.00)` | :arrow_down: |
   | [.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==) | `63.17% <73.33%> (+0.46%)` | `38.00 <5.00> (+5.00)` | |
   | ... and [17 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer). Last update [31f2ef1...9007371](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083


   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1) Report
   > Merging [#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.06%`.
   > The diff coverage is `50.34%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3035      +/-   ##
   ============================================
   + Coverage     45.66%   45.73%   +0.06%     
   - Complexity     9296     9325      +29     
   ============================================
     Files          1956     1960       +4     
     Lines         74397    74500     +103     
     Branches       8247     8259      +12     
   ============================================
   + Hits          33977    34073      +96     
   - Misses        37242    37245       +3     
   - Partials       3178     3182       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `7.04% <0.00%> (-0.10%)` | `9.00 <0.00> (ø)` | |
   | [...org/apache/gobblin/azkaban/AzkabanJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Kb2JMYXVuY2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `2.70% <0.00%> (ø)` | `1.00 <0.00> (ø)` | |
   | [...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==) | `15.20% <0.00%> (-0.21%)` | `4.00 <0.00> (ø)` | |
   | [...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTWV0cmljUmVwb3J0ZXJFeGNlcHRpb24uamF2YQ==) | `28.57% <28.57%> (ø)` | `1.00 <1.00> (?)` | |
   | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `33.03% <53.19%> (+14.22%)` | `30.00 <6.00> (+15.00)` | |
   | [...blin/runtime/services/MetricsReportingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc2VydmljZXMvTWV0cmljc1JlcG9ydGluZ1NlcnZpY2UuamF2YQ==) | `73.68% <58.33%> (-26.32%)` | `5.00 <3.00> (+2.00)` | :arrow_down: |
   | [...pache/gobblin/runtime/mapreduce/MRJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL01SSm9iTGF1bmNoZXIuamF2YQ==) | `53.45% <68.75%> (+0.40%)` | `19.00 <0.00> (ø)` | |
   | ... and [18 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer). Last update [31f2ef1...54c716f](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083


   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1) Report
   > Merging [#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **decrease** coverage by `36.37%`.
   > The diff coverage is `16.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #3035       +/-   ##
   ============================================
   - Coverage     45.66%   9.29%   -36.38%     
   + Complexity     9296    1700     -7596     
   ============================================
     Files          1956    1960        +4     
     Lines         74397   74487       +90     
     Branches       8247    8257       +10     
   ============================================
   - Hits          33977    6923    -27054     
   - Misses        37242   66888    +29646     
   + Partials       3178     676     -2502     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `1.89% <0.00%> (-5.25%)` | `1.00 <0.00> (-8.00)` | |
   | [...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==) | `0.00% <0.00%> (-18.81%)` | `0.00 <0.00> (-15.00)` | |
   | [...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTWV0cmljUmVwb3J0ZXJFeGNlcHRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...apache/gobblin/metrics/MultiReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvTXVsdGlSZXBvcnRlckV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...a/org/apache/gobblin/metrics/ReporterSinkType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvUmVwb3J0ZXJTaW5rVHlwZS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../java/org/apache/gobblin/metrics/ReporterType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvUmVwb3J0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...he/gobblin/metrics/kafka/KafkaReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...blin/runtime/services/MetricsReportingService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvc2VydmljZXMvTWV0cmljc1JlcG9ydGluZ1NlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00 <0.00> (-3.00)` | |
   | [...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=) | `0.00% <0.00%> (-2.71%)` | `0.00 <0.00> (-1.00)` | |
   | ... and [1042 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer). Last update [31f2ef1...9007371](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] asfgit closed pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
htran1 commented on a change in pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#discussion_r440390208



##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java
##########
@@ -783,8 +786,26 @@ protected void setup(Context context) {
       if (Boolean.valueOf(
           configuration.get(ConfigurationKeys.METRICS_ENABLED_KEY, ConfigurationKeys.DEFAULT_METRICS_ENABLED))) {
         this.jobMetrics = Optional.of(JobMetrics.get(this.jobState));
-        this.jobMetrics.get()
-            .startMetricReportingWithFileSuffix(gobblinJobState, context.getTaskAttemptID().toString());
+        try {
+          this.jobMetrics.get()
+              .startMetricReportingWithFileSuffix(gobblinJobState, context.getTaskAttemptID().toString());
+        } catch (MultiReporterException ex) {
+          //Fail the task if metric/event reporting failure is configured to be fatal.
+          boolean isMetricReportingFailureFatal = Boolean.valueOf(configuration
+              .get(ConfigurationKeys.GOBBLIN_TASK_METRIC_REPORTING_FAILURE_FATAL,
+                  Boolean.toString(ConfigurationKeys.DEFAULT_GOBBLIN_TASK_METRIC_REPORTING_FAILURE_FATAL)));
+          boolean isEventReportingFailureFatal = Boolean.valueOf(configuration
+              .get(ConfigurationKeys.GOBBLIN_TASK_EVENT_REPORTING_FAILURE_FATAL,
+                  Boolean.toString(ConfigurationKeys.DEFAULT_GOBBLIN_TASK_EVENT_REPORTING_FAILURE_FATAL)));
+          for (MetricReporterException e : ex.getExceptions()) {
+            if ((isMetricReportingFailureFatal && e.getReporterType().equals(ReporterType.METRIC)) || (

Review comment:
       Maybe the throw can be moved outside the loop so that all the errors are logged.

##########
File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/services/MetricsReportingService.java
##########
@@ -21,25 +21,52 @@
 
 import com.google.common.util.concurrent.AbstractIdleService;
 
+import lombok.extern.slf4j.Slf4j;
+
 import org.apache.gobblin.metrics.GobblinMetrics;
+import org.apache.gobblin.metrics.MetricReporterException;
+import org.apache.gobblin.metrics.MultiReporterException;
+import org.apache.gobblin.metrics.ReporterType;
+import org.apache.gobblin.util.PropertiesUtils;
 
 
 /**
  * A {@link com.google.common.util.concurrent.Service} for handling life cycle events around {@link GobblinMetrics}.
  */
+@Slf4j
 public class MetricsReportingService extends AbstractIdleService {
+  public static final String METRICS_REPORTING_FAILURE_FATAL_KEY = "metrics.reporting.failure.fatal";
+  public static final String EVENT_REPORTING_FAILURE_FATAL_KEY = "event.reporting.failure.fatal";
+
+  public static final String DEFAULT_METRICS_REPORTING_FAILURE_FATAL = "false";
+  public static final String DEFAULT_EVENT_REPORTING_FAILURE_FATAL = "false";
 
   private final Properties properties;
   private final String appId;
+  private final boolean isMetricReportingFailureFatal;
+  private final boolean isEventReportingFailureFatal;
 
   public MetricsReportingService(Properties properties, String appId) {
     this.properties = properties;
     this.appId = appId;
+    this.isMetricReportingFailureFatal = PropertiesUtils.getPropAsBoolean(properties, METRICS_REPORTING_FAILURE_FATAL_KEY, DEFAULT_METRICS_REPORTING_FAILURE_FATAL);
+    this.isEventReportingFailureFatal = PropertiesUtils.getPropAsBoolean(properties, EVENT_REPORTING_FAILURE_FATAL_KEY, DEFAULT_EVENT_REPORTING_FAILURE_FATAL);
   }
 
   @Override
   protected void startUp() throws Exception {
-    GobblinMetrics.get(this.appId).startMetricReporting(this.properties);
+    try {
+      GobblinMetrics.get(this.appId).startMetricReporting(this.properties);
+    } catch (MultiReporterException ex) {
+      for (MetricReporterException e: ex.getExceptions()) {

Review comment:
       This shows up three times, so maybe pull into a utility method.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] sv2000 closed pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
sv2000 closed pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] codecov-commenter edited a comment on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642214083


   # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=h1) Report
   > Merging [#3035](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/31f2ef1478c3b5d4887cfc772f0e85057cde1c56&el=desc) will **increase** coverage by `0.13%`.
   > The diff coverage is `25.78%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3035      +/-   ##
   ============================================
   + Coverage     45.66%   45.80%   +0.13%     
   - Complexity     9296     9347      +51     
   ============================================
     Files          1956     1961       +5     
     Lines         74397    74547     +150     
     Branches       8247     8262      +15     
   ============================================
   + Hits          33977    34145     +168     
   + Misses        37242    37203      -39     
   - Partials       3178     3199      +21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
   | [...ache/gobblin/compaction/mapreduce/MRCompactor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdG9yLmphdmE=) | `7.04% <0.00%> (-0.10%)` | `9.00 <0.00> (ø)` | |
   | [...pache/gobblin/metrics/MetricReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NZXRyaWNSZXBvcnRlckV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...apache/gobblin/metrics/MultiReporterException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9NdWx0aVJlcG9ydGVyRXhjZXB0aW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...a/org/apache/gobblin/metrics/ReporterSinkType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9SZXBvcnRlclNpbmtUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [.../java/org/apache/gobblin/metrics/ReporterType.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9SZXBvcnRlclR5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...bblin/metrics/reporter/util/MetricReportUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci91dGlsL01ldHJpY1JlcG9ydFV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...org/apache/gobblin/azkaban/AzkabanJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9hemthYmFuL0F6a2FiYW5Kb2JMYXVuY2hlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | [...bblin/metrics/kafka/KafkaEventReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FFdmVudFJlcG9ydGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | [...blin/metrics/kafka/KafkaMetricReporterFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FNZXRyaWNSZXBvcnRlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
   | ... and [35 more](https://codecov.io/gh/apache/incubator-gobblin/pull/3035/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=footer). Last update [31f2ef1...fc0acb5](https://codecov.io/gh/apache/incubator-gobblin/pull/3035?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-gobblin] sv2000 commented on pull request #3035: [GOBBLIN-1127] Provide an option to make metric reporting instantiation failure fatal

Posted by GitBox <gi...@apache.org>.
sv2000 commented on pull request #3035:
URL: https://github.com/apache/incubator-gobblin/pull/3035#issuecomment-642348797


   @htran1 @autumnust Please review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org