You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/07/15 12:49:29 UTC
[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/4348
[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided…
- [x] General
- The pull request references the related JIRA issue (" [FLINK-7101][table] add condition of !stateCleaningEnabled is avoided non-grouped window state to be cleaned up too early")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-7101-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4348.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4348
----
commit 1c006299c8b8a169e346ef776cf9c5f5d7af20e0
Author: sunjincheng121 <su...@gmail.com>
Date: 2017-07-15T11:43:30Z
[FLINK-7101][table] add condition of !stateCleaningEnabled is avoided non-grouped window state to be cleaned up too early
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4348: [FLINK-7101][table] add condition of !stateCleaningEnable...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/4348
Hi @fhueske Thanks for the review. I'll address the description. and merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/4348#discussion_r127677326
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala ---
@@ -131,7 +131,8 @@ class GroupAggProcessFunction(
// if this was not the first row and we have to emit retractions
if (generateRetraction && !firstRow) {
- if (prevRow.row.equals(newRow.row)) {
+ // the condition of !stateCleaningEnabled is avoided state to be cleaned up too early
--- End diff --
I would move the description into the `if` block and modify it as follows:
```
// newRow is the same as before and state cleaning is not enabled. We do not emit retraction and acc message.
// If state cleaning is enabled, we have to emit messages to prevent too early state eviction of downstream operators.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/4348#discussion_r127715580
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/GroupAggProcessFunction.scala ---
@@ -131,7 +131,8 @@ class GroupAggProcessFunction(
// if this was not the first row and we have to emit retractions
if (generateRetraction && !firstRow) {
- if (prevRow.row.equals(newRow.row)) {
+ // the condition of !stateCleaningEnabled is avoided state to be cleaned up too early
--- End diff --
Make sense to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4348: [FLINK-7101][table] add condition of !stateCleanin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4348
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---