[GitHub] dgrove-oss closed pull request #1011: Add nodejs:10 kind for wskdeploy

[GitBox <gi...@apache.org>]

dgrove-oss closed pull request #1011: Add nodejs:10 kind for wskdeploy
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/1011
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/runtimes/runtimes.json b/runtimes/runtimes.json
index f47b4fdd..29bd3a24 100644
--- a/runtimes/runtimes.json
+++ b/runtimes/runtimes.json
@@ -53,6 +53,20 @@
                     "attachmentName": "codefile",
                     "attachmentType": "text/plain"
                 }
+            },
+            {
+                "kind": "nodejs:10",
+                "default": false,
+                "image": {
+                    "prefix": "openwhisk",
+                    "name": "action-nodejs-v10",
+                    "tag": "latest"
+                },
+                "deprecated": false,
+                "attached": {
+                    "attachmentName": "codefile",
+                    "attachmentType": "text/plain"
+                }
             }
         ],
         "python": [
diff --git a/specification/html/spec_actions.md b/specification/html/spec_actions.md
index bc74dd93..05216757 100644
--- a/specification/html/spec_actions.md
+++ b/specification/html/spec_actions.md
@@ -134,15 +134,15 @@ These packages may vary by OpenWhisk release; examples of supported runtimes as
 
 | Runtime value | OpenWhisk kind | Docker image name | Description |
 |:---|:---|:---|:---|
-| nodejs | nodejs | openwhisk/nodejsaction:latest | Latest NodeJS runtime |
-| nodejs@6 | nodejs:6 | openwhisk/nodejs6action:latest | Latest NodeJS 6 runtime |
+| nodejs@10 | nodejs:10 | openwhisk/action-nodejs-v8:latest | Latest NodeJS 10 runtime |
 | nodejs@8 | nodejs:8 | openwhisk/action-nodejs-v8:latest | Latest NodeJS 8 runtime |
-| java, java@8 | java | openwhisk/java8action:latest | Latest Java (8) language runtime |
+| nodejs@6 | nodejs:6 | openwhisk/nodejs6action:latest | Latest NodeJS 6 runtime |
+| java | java | openwhisk/java8action:latest | Latest Java (8) language runtime |
+| php, php@7.2 | php:7.2 | openwhisk/action-php-v7.2:latest | Latest PHP (7.2) language runtime |
 | php, php@7.1 | php:7.1 | openwhisk/action-php-v7.1:latest | Latest PHP (7.1) language runtime |
-| python, python@2 | python:2 | openwhisk/python2action:latest | Latest Python 2 language runtime |
 | python@3 | python:3 | openwhisk/python3action:latest | Latest Python 3 language runtime |
-| swift | swift | openwhisk/swiftaction:latest | Latest Swift language runtime |
-| swift@3 | swift | openwhisk/swift3action:latest | Latest Swift 3 language runtime |
+| python, python@2 | python:2 | openwhisk/python2action:latest | Latest Python 2 language runtime |s
+| swift@4.1 | swift | openwhisk/action-swift-v4.1:latest | Latest Swift 4.1 language runtime |
 | swift@3.1.1 | swift | openwhisk/action-swift-v3.1.1:latest | Latest Swift 3.1.1 language runtime |
 | language:default | N/A | N/A | Permit the OpenWhisk platform to select the correct default language runtime. |
 
diff --git a/tests/src/integration/runtimetests/manifest.yaml b/tests/src/integration/runtimetests/manifest.yaml
index 738057b8..04539e1e 100644
--- a/tests/src/integration/runtimetests/manifest.yaml
+++ b/tests/src/integration/runtimetests/manifest.yaml
@@ -26,6 +26,16 @@ packages:
                     place: string
                 outputs:
                     payload: string
+            greetingnodejs10-with-explicit-runtime:
+                web-export: true
+                version: 1.0
+                function: src/greeting.js
+                runtime: nodejs:10
+                inputs:
+                    name: string
+                    place: string
+                outputs:
+                    payload: string
             greetingphp-with-explicit-runtime:
                 web-export: true
                 version: 1.0


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services