You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "msokolov (via GitHub)" <gi...@apache.org> on 2025/01/08 18:05:13 UTC

[PR] fix for gh#14110: stablize BpVectorReordered heuristic [lucene]

msokolov opened a new pull request, #14117:
URL: https://github.com/apache/lucene/pull/14117

   It turned out that the initial shuffled order resulted in a left / right split with centroids that were very close together, the heuristic would terminate without doing any swaps, causing the test to fail. The test assumes that at least one swap will happen in the first iteration level. I changed the heuristic to be based on the size of the difference between the two centroids rather than the sum of their sizes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] fix for gh#14110: stablize BpVectorReordered heuristic [lucene]

Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov merged PR #14117:
URL: https://github.com/apache/lucene/pull/14117


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [PR] fix for gh#14110: stablize BpVectorReordered heuristic [lucene]

Posted by "msokolov (via GitHub)" <gi...@apache.org>.
msokolov commented on PR #14117:
URL: https://github.com/apache/lucene/pull/14117#issuecomment-2578804815

   BTW this also fixed failures like this one:
   
   ```
   FAILED:  org.apache.lucene.misc.index.TestBpVectorReorderer.testQuantizedIndex
   
   Error Message:
   java.lang.AssertionError: out of order at 18
   
   Stack Trace:
   java.lang.AssertionError: out of order at 18
           at __randomizedtesting.SeedInfo.seed([CC2D27D6F33B8476:7613F311A04F402E]:0)
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org