You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/08 01:35:49 UTC

[GitHub] HeartSaVioR commented on a change in pull request #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration

HeartSaVioR commented on a change in pull request #23732: [SPARK-26389][SS] Add force delete temp checkpoint configuration
URL: https://github.com/apache/spark/pull/23732#discussion_r254931064
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -907,6 +907,12 @@ object SQLConf {
     .stringConf
     .createOptional
 
+  val FORCE_DELETE_TEMP_CHECKPOINT_LOCATION =
+    buildConf("spark.sql.streaming.forceDeleteTempCheckpointLocation")
+      .doc("When true, enable temporary checkpoint locations force delete.")
 
 Review comment:
   nit: I'd like to have this to be a valid and more described sentence like other configurations, especially this feature is only documented here. One example for me, `When true, Spark always deletes temporary checkpoint locations for success queries.`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org