[jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

- bump guava version to 21.0
- fix DimensionData test

this is required for https://github.com/jclouds/jclouds/pull/1197
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/436

-- Commit Summary --

  * Upgrade to java8

-- File Changes --

    M dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/features/NetworkApiMockTest.java (9)
    M dimensiondata/src/test/java/org/jclouds/dimensiondata/cloudcontrol/internal/BaseDimensionDataCloudControlApiLiveTest.java (4)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/436.patch
https://github.com/jclouds/jclouds-labs/pull/436.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

merged at [master](http://git-wip-us.apache.org/repos/asf/jclouds-labs/commit/1b5dd9fe)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391017677

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrew Phillips <no...@github.com>]

> makes sense?

Yes, clear, thanks. Just wanted to make sure we weren't missing any code that we were intending to add ;-)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391115128

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

sure thanks for double-checking it

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391117526

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

andreaturli commented on this pull request.



> @@ -40,7 +40,7 @@
 import java.util.Properties;
 import java.util.Set;
 
-import static com.google.common.util.concurrent.MoreExecutors.sameThreadExecutor;
+import static com.google.common.util.concurrent.MoreExecutors.newDirectExecutorService;

@demobox I think this is required because of guava 21 inherited from jclouds/jclouds

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-122320272

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrew Phillips <no...@github.com>]

> bump guava version to 21.0

@andreaturli Just to clarify: is this part of this PR? I didn't see any code change related to that, but it may have been removed or after an underlying merge.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391109043

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

@demobox I think guava21 updates are incidentally required as we updated guava21 in jclouds/jclouds, so technically the PR doesn't bump guava version for jclouds-labs in its pom.xml but it happens because of the upstream changes. makes sense?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391114608

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrew Gaul <no...@github.com>]

gaul approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-121802549

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Ignasi Barrera <no...@github.com>]

nacx approved this pull request.





-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#pullrequestreview-122199296

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

Closed #436.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#event-1639523209

Re: [jclouds/jclouds-labs] Upgrade to java8 (#436)

[Andrea Turli <no...@github.com>]

cool, thanks @nacx and @gaul merging now

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/436#issuecomment-391014797