[jira] [Commented] (YARN-3489) RMServerUtils.validateResourceRequests should only obtain queue info once

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502350#comment-14502350 ] 

Hadoop QA commented on YARN-3489:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12726511/YARN-3489.01.patch
  against trunk revision 8511d80.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-YARN-Build/7394//console

This message is automatically generated.

> RMServerUtils.validateResourceRequests should only obtain queue info once
> -------------------------------------------------------------------------
>
>                 Key: YARN-3489
>                 URL: https://issues.apache.org/jira/browse/YARN-3489
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: resourcemanager
>    Affects Versions: 2.6.0
>            Reporter: Jason Lowe
>            Assignee: Varun Saxena
>         Attachments: YARN-3489.01.patch
>
>
> Since the label support was added we now get the queue info for each request being validated in SchedulerUtils.validateResourceRequest.  If validateResourceRequests needs to validate a lot of requests at a time (e.g.: large cluster with lots of varied locality in the requests) then it will get the queue info for each request.  Since we build the queue info this generates a lot of unnecessary garbage, as the queue isn't changing between requests.  We should grab the queue info once and pass it down rather than building it again for each request.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)