You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by maddingo <gi...@git.apache.org> on 2016/11/17 19:15:38 UTC
[GitHub] incubator-fineract pull request #246: Put gradle version in build.gradle and...
GitHub user maddingo opened a pull request:
https://github.com/apache/incubator-fineract/pull/246
Put gradle version in build.gradle and avoid having to download the correct gradle version prior to building
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maddingo/incubator-fineract develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-fineract/pull/246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #246
----
commit f0995f38d336e63a7899983985d8d7ae6e113863
Author: Martin Goldhahn <mg...@gmail.com>
Date: 2016-11-17T18:54:09Z
Align Gradle version with requirements, also avoiding the need to download the gradle-warapper.jar
commit 8963e35ff0e30df6f351ee8df0dbaaf3d980f4e3
Author: Martin Goldhahn <mg...@gmail.com>
Date: 2016-11-17T19:11:37Z
Delete required build step, correct gradle version is downloaded by gradlew
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
@maddingo Have you tested by removing existing gradle jar file? Is it downloading and build happening properly?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by maddingo <gi...@git.apache.org>.
Github user maddingo commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
I am not a Gradle wizzard. But here is how I understand it. Gradle needs the gradle jar file to work. But what the change does it ensures that the right gradle version is used and you don't require the developer to download and set up the right gradle version manually. If there is a requirement for a specific gradle version, it should be put in the build tool.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by maddingo <gi...@git.apache.org>.
Github user maddingo commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
@nazeer1100126 Thanks for trying my PR.
I can reproduce the steps I am running with the following Dockerfile, i.e. on a clean environment:
```
FROM ubuntu:16.04
RUN apt-get -y update && apt-get -y install git openjdk-8-jdk
RUN git clone https://github.com/maddingo/incubator-fineract && cd incubator-fineract/fineract-provider && ./gradlew war
```
Which tasks are you trying to run?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by maddingo <gi...@git.apache.org>.
Github user maddingo commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
@nazeer1100126 Sorry for the late reply. I think you can close this issue. I found a way to set up my development environment without this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract pull request #246: Put gradle version in build.gradle and...
Posted by maddingo <gi...@git.apache.org>.
Github user maddingo closed the pull request at:
https://github.com/apache/incubator-fineract/pull/246
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
I tried your changes. But I got the following error.
Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain
It is not downloading the gradle wrapper jar file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-fineract issue #246: Put gradle version in build.gradle and avoid ...
Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on the issue:
https://github.com/apache/incubator-fineract/pull/246
You are able to run as already gradle-wrapper jar is available in https://github.com/apache/incubator-fineract/tree/develop/fineract-provider/gradle/wrapper/ directory. The purpose of your PR is not to download the jar and place in this directory. So I have removed this jar from mentioned directory and tried to build gradlew clean build. But it didn't work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---