You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2017/08/30 08:29:53 UTC
Re: Review Request 61981: Added unit test for killing the default
executor process.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/
-----------------------------------------------------------
(Updated Aug. 30, 2017, 1:29 a.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
Summary (updated)
-----------------
Added unit test for killing the default executor process.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
Added unit test for killing the default executor process.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
Diff: https://reviews.apache.org/r/61981/diff/2/
Changes: https://reviews.apache.org/r/61981/diff/1-2/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 11:23 p.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
Added unit test for killing the default executor process.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp 138c428b56f71776e29aff3e97548d952a639045
Diff: https://reviews.apache.org/r/61981/diff/4/
Changes: https://reviews.apache.org/r/61981/diff/3-4/
Testing (updated)
-------
make check
Failed before the fix at r/62005
Thanks,
Gilbert Song
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184224
-----------------------------------------------------------
Bad patch!
Reviews applied: [61989, 61981]
Logs available here: http://104.210.40.105/logs/master/61981
- Mesos Reviewbot Windows
On Aug. 30, 2017, 11:45 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 11:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for killing the default executor process.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
>
>
> Diff: https://reviews.apache.org/r/61981/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Gilbert Song <so...@gmail.com>.
> On Aug. 30, 2017, 9:41 p.m., Gastón Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1419 (patched)
> > <https://reviews.apache.org/r/61981/diff/3/?file=1808295#file1808295line1419>
> >
> > This future isn't needed, waiting for `subscribed` bellow should be enough.
Keep it the same as others in this file since it ssems more explicitly to await for the connection ready first.
> On Aug. 30, 2017, 9:41 p.m., Gastón Kleiman wrote:
> > src/tests/default_executor_tests.cpp
> > Lines 1455 (patched)
> > <https://reviews.apache.org/r/61981/diff/3/?file=1808295#file1808295line1455>
> >
> > This should be an assertion instead of an expectation.
Good catch.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184235
-----------------------------------------------------------
On Aug. 30, 2017, 4:45 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 4:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for killing the default executor process.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
>
>
> Diff: https://reviews.apache.org/r/61981/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184235
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp
Lines 1386 (patched)
<https://reviews.apache.org/r/61981/#comment260331>
s/will not have discard/will not be discarded/
src/tests/default_executor_tests.cpp
Lines 1417 (patched)
<https://reviews.apache.org/r/61981/#comment260332>
This seems to be used only in line 1421, do we really need to create this alias?
src/tests/default_executor_tests.cpp
Lines 1419 (patched)
<https://reviews.apache.org/r/61981/#comment260329>
This future isn't needed, waiting for `subscribed` bellow should be enough.
src/tests/default_executor_tests.cpp
Lines 1455 (patched)
<https://reviews.apache.org/r/61981/#comment260330>
This should be an assertion instead of an expectation.
- Gastón Kleiman
On Aug. 30, 2017, 11:45 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 11:45 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for killing the default executor process.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
>
>
> Diff: https://reviews.apache.org/r/61981/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/
-----------------------------------------------------------
(Updated Aug. 30, 2017, 4:45 p.m.)
Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
Bugs: MESOS-7926
https://issues.apache.org/jira/browse/MESOS-7926
Repository: mesos
Description
-------
Added unit test for killing the default executor process.
Diffs (updated)
-----
src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
Diff: https://reviews.apache.org/r/61981/diff/3/
Changes: https://reviews.apache.org/r/61981/diff/2-3/
Testing
-------
Thanks,
Gilbert Song
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184137
-----------------------------------------------------------
Bad patch!
Reviews applied: [61989, 61981]
Logs available here: http://104.210.40.105/logs/master/61981
- Mesos Reviewbot Windows
On Aug. 30, 2017, 8:29 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 8:29 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for killing the default executor process.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
>
>
> Diff: https://reviews.apache.org/r/61981/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 61981: Added unit test for killing the default
executor process.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61981/#review184136
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/default_executor_tests.cpp
Lines 1384 (patched)
<https://reviews.apache.org/r/61981/#comment260197>
Can you please add some comments to explain the purpose of this test?
src/tests/default_executor_tests.cpp
Lines 1455 (patched)
<https://reviews.apache.org/r/61981/#comment260198>
We do not need this comment.
src/tests/default_executor_tests.cpp
Lines 1465 (patched)
<https://reviews.apache.org/r/61981/#comment260199>
Ditto.
- Qian Zhang
On Aug. 30, 2017, 4:29 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61981/
> -----------------------------------------------------------
>
> (Updated Aug. 30, 2017, 4:29 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Benjamin Mahler, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-7926
> https://issues.apache.org/jira/browse/MESOS-7926
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added unit test for killing the default executor process.
>
>
> Diffs
> -----
>
> src/tests/default_executor_tests.cpp afe0afabf784fb65eb833beadd3c584722c321e1
>
>
> Diff: https://reviews.apache.org/r/61981/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>