You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/08 07:21:10 UTC
[GitHub] [commons-configuration] jansohn opened a new pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
jansohn opened a new pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76
Code which reproduces the unclosed file handle problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn closed pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn closed pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705753612
I added this:
commit b84a0ef5ad561e64e98f13e8b912003fda9f5469
Author: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Committer: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Parent: b773e0c309c5fbbe0ab4d36cd47370759589571b (Javadoc: Replace <code></code> HTML tags with Javadoc {@code} notation.)
Branches: master, origin/master
Add and ignore
testFileBasedConfigurationBuilder.testGetConfigurationLoadFromJarFile
based on https://github.com/apache/commons-configuration/pull/76
Fails on Windows:
java.lang.AssertionError: Unable to clean up temporary folder
C:\Users\ggregory\AppData\Local\Temp\junit4296513623415900710
at org.junit.Assert.fail(Assert.java:89)
at org.junit.rules.TemporaryFolder.delete(TemporaryFolder.java:274)
at org.junit.rules.TemporaryFolder.after(TemporaryFolder.java:138)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:59)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-706352905
Should I close this PR since you added a test case like this to the master already? Do you have any idea why it fails on Windows?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-768393654
Actually it seems that it didn't make it into version 2.8.0...
@garydgregory can you confirm this? Release notes indicate that it was added for 2.8.0 but I cannot find the specific class in the JAR file (neither Bintray nor Maven Central).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-770270919
As we have many components within Apache Commons, the confusion is
understandable :-) ! There is no release date set but it is on my to
do list after IO and LANG.
Gary
On Fri, Jan 29, 2021, 05:28 jansohn <no...@github.com> wrote:
> Well, someone already did upload a version 2.8.0 for commons-io on Maven
> Central and Bintray:
>
> - https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
> - https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0
>
> The title of this ticket is about the CONFIGURATION component, not IO.
> What am I missing?
>
> Well, this is embarrassing. I mixed up the two components...
>
> Do you have an estimate when the new version 2.8.0 of
> commons-configuration will be released?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/commons-configuration/pull/76#issuecomment-769720508>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAJB6NZZ5IHKKWNF2EXGW63S4KEV7ANCNFSM4SILZICA>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705392379
Seems to be a Windows specific problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705753612
I added this:
commit b84a0ef5ad561e64e98f13e8b912003fda9f5469
Author: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Committer: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Parent: b773e0c309c5fbbe0ab4d36cd47370759589571b (Javadoc: Replace <code></code> HTML tags with Javadoc {@code} notation.)
Branches: master, origin/master
Add and ignore
testFileBasedConfigurationBuilder.testGetConfigurationLoadFromJarFile
based on https://github.com/apache/commons-configuration/pull/76
Fails on Windows:
java.lang.AssertionError: Unable to clean up temporary folder
C:\Users\ggregory\AppData\Local\Temp\junit4296513623415900710
at org.junit.Assert.fail(Assert.java:89)
at org.junit.rules.TemporaryFolder.delete(TemporaryFolder.java:274)
at org.junit.rules.TemporaryFolder.after(TemporaryFolder.java:138)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:59)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-769720508
>
>
> > Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:
> >
> > * https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
> > * https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0
>
> The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?
Well, this is embarrassing. I mixed up the two components...
Do you have an estimate when the new version 2.8.0 of commons-configuration will be released?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-768632513
Version 2.8.0 is not out yet. See previous comment with link to git commit. Let us know if that does not match up with what you are looking for.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on a change in pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#discussion_r501742019
##########
File path: src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java
##########
@@ -136,6 +141,31 @@ public void testGetConfigurationLoadFromFile()
.getFileHandler().getContent());
}
+ /**
+ * Tests whether a configuration is loaded from a JAR file if a location is
+ * provided.
+ */
+ @Test
+ public void testGetConfigurationLoadFromJarFile()
+ throws ConfigurationException, IOException
+ {
+ URL jarResource = getClass().getClassLoader().getResource("test.jar");
+ assertNotNull(jarResource);
+ final Path testJar = Paths.get(folder.getRoot().getAbsolutePath(), "test.jar");
+ Files.copy(jarResource.openStream(), testJar);
Review comment:
This stream needs to be managed in a try-with-resources block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-706354654
You can close this PR or rebase it on master if you want to offer a fix or more tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705392379
Seems to be a Windows specific problem...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-769176607
> Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:
>
> * https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
> * https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0
The title of this ticket is about the CONFIGURATION component, not IO. What am I missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] sebbASF commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-706681837
It fails on Windows because the OS locks the jar files that it opens.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory edited a comment on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705753612
I added tweaked test with:
```
commit b84a0ef5ad561e64e98f13e8b912003fda9f5469
Author: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Committer: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Parent: b773e0c309c5fbbe0ab4d36cd47370759589571b (Javadoc: Replace <code></code> HTML tags with Javadoc {@code} notation.)
Branches: master, origin/master
Add and ignore
testFileBasedConfigurationBuilder.testGetConfigurationLoadFromJarFile
based on https://github.com/apache/commons-configuration/pull/76
Fails on Windows:
java.lang.AssertionError: Unable to clean up temporary folder
C:\Users\ggregory\AppData\Local\Temp\junit4296513623415900710
at org.junit.Assert.fail(Assert.java:89)
at org.junit.rules.TemporaryFolder.delete(TemporaryFolder.java:274)
at org.junit.rules.TemporaryFolder.after(TemporaryFolder.java:138)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:59)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory commented on a change in pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory commented on a change in pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#discussion_r501742019
##########
File path: src/test/java/org/apache/commons/configuration2/builder/TestFileBasedConfigurationBuilder.java
##########
@@ -136,6 +141,31 @@ public void testGetConfigurationLoadFromFile()
.getFileHandler().getContent());
}
+ /**
+ * Tests whether a configuration is loaded from a JAR file if a location is
+ * provided.
+ */
+ @Test
+ public void testGetConfigurationLoadFromJarFile()
+ throws ConfigurationException, IOException
+ {
+ URL jarResource = getClass().getClassLoader().getResource("test.jar");
+ assertNotNull(jarResource);
+ final Path testJar = Paths.get(folder.getRoot().getAbsolutePath(), "test.jar");
+ Files.copy(jarResource.openStream(), testJar);
Review comment:
This stream needs to be managed in a try-with-resources block.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] garydgregory edited a comment on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
garydgregory edited a comment on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-705753612
I added tweaked test with:
```
commit b84a0ef5ad561e64e98f13e8b912003fda9f5469
Author: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Committer: Gary Gregory <ga...@gmail.com> 2020-10-08 14:42:08
Parent: b773e0c309c5fbbe0ab4d36cd47370759589571b (Javadoc: Replace <code></code> HTML tags with Javadoc {@code} notation.)
Branches: master, origin/master
Add and ignore
testFileBasedConfigurationBuilder.testGetConfigurationLoadFromJarFile
based on https://github.com/apache/commons-configuration/pull/76
Fails on Windows:
java.lang.AssertionError: Unable to clean up temporary folder
C:\Users\ggregory\AppData\Local\Temp\junit4296513623415900710
at org.junit.Assert.fail(Assert.java:89)
at org.junit.rules.TemporaryFolder.delete(TemporaryFolder.java:274)
at org.junit.rules.TemporaryFolder.after(TemporaryFolder.java:138)
at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:59)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.eclipse.jdt.internal.junit4.runner.JUnit4TestReference.run(JUnit4TestReference.java:89)
at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:41)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:542)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:770)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:464)
at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-768875447
Well, someone already did upload a version 2.8.0 for commons-io on Maven Central and Bintray:
- https://repo1.maven.org/maven2/commons-io/commons-io/2.8.0/
- https://bintray.com/bintray/jcenter/commons-io%3Acommons-io/2.8.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-configuration] jansohn commented on pull request #76: CONFIGURATION-794: add test which demonstrates unclosed file handle
Posted by GitBox <gi...@apache.org>.
jansohn commented on pull request #76:
URL: https://github.com/apache/commons-configuration/pull/76#issuecomment-707690587
For future references: Fix was provided with commit https://github.com/apache/commons-configuration/commit/e0888d8afc1598a0e2b801d34023ba81ede32ee3#diff-6dd674b6f0044cb5f3b6a7e2ffc1800cc85bea034c7a87617f87f2a4ab38cb08R142 available from version 2.8.0+.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org