You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@archiva.apache.org by "Carlos Costa e Silva (JIRA)" <ji...@codehaus.org> on 2008/04/11 18:36:58 UTC

[jira] Created: (MRM-778) DefaultDavServerManager.createServer doesn't create server

DefaultDavServerManager.createServer doesn't create server
----------------------------------------------------------

                 Key: MRM-778
                 URL: http://jira.codehaus.org/browse/MRM-778
             Project: Archiva
          Issue Type: Bug
          Components: WebDAV interface
    Affects Versions: 1.1
            Reporter: Carlos Costa e Silva
            Priority: Blocker


In DefaultDavServerManager, the createServer method instead of creating a new server each time it's called is reusing the same server for all paths.

The "DavServerComponent server" needs to be created each time createServer is called instead of being injected by plexus when the DavServerManager is created.

This bug makes multiple repositories with different settings not work. 

For example "internal" has snapshots disabled, while "snapshots" has snapshots enabled. When a request comes for the snapshots repository, webdav is using the metadata for the "internal" server which has snapshots disabled and refuses to download snapshots. 

It's possible that if it downloaded snapshots they would be put on the wrong repository ("internal"), but I haven't verified this.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-778) DefaultDavServerManager.createServer doesn't create server

Posted by "Carlos Costa e Silva (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Costa e Silva updated MRM-778:
-------------------------------------

    Attachment: ServerManager.zip

Patch v 1.0 for this issue.

> DefaultDavServerManager.createServer doesn't create server
> ----------------------------------------------------------
>
>                 Key: MRM-778
>                 URL: http://jira.codehaus.org/browse/MRM-778
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.1
>            Reporter: Carlos Costa e Silva
>            Priority: Blocker
>         Attachments: ServerManager.zip
>
>
> In DefaultDavServerManager, the createServer method instead of creating a new server each time it's called is reusing the same server for all paths.
> The "DavServerComponent server" needs to be created each time createServer is called instead of being injected by plexus when the DavServerManager is created.
> This bug makes multiple repositories with different settings not work. 
> For example "internal" has snapshots disabled, while "snapshots" has snapshots enabled. When a request comes for the snapshots repository, webdav is using the metadata for the "internal" server which has snapshots disabled and refuses to download snapshots. 
> It's possible that if it downloaded snapshots they would be put on the wrong repository ("internal"), but I haven't verified this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-778) DefaultDavServerManager.createServer doesn't create server

Posted by "Carlos Costa e Silva (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=130826#action_130826 ] 

Carlos Costa e Silva commented on MRM-778:
------------------------------------------

Patch follows for this issue.

application.xml: remove injection of DavServerComponent to DavServerManager.

DavServerManager.createServer: add parameter ServletConfig config .

DefaultDavServerManager.createSerber: add parameter ServletConfig config and fetch server from spring.

BasicWebDavServlet and MultiplexedWebDavServlet add config parameter to createServer call.


> DefaultDavServerManager.createServer doesn't create server
> ----------------------------------------------------------
>
>                 Key: MRM-778
>                 URL: http://jira.codehaus.org/browse/MRM-778
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.1
>            Reporter: Carlos Costa e Silva
>            Priority: Blocker
>         Attachments: ServerManager.zip
>
>
> In DefaultDavServerManager, the createServer method instead of creating a new server each time it's called is reusing the same server for all paths.
> The "DavServerComponent server" needs to be created each time createServer is called instead of being injected by plexus when the DavServerManager is created.
> This bug makes multiple repositories with different settings not work. 
> For example "internal" has snapshots disabled, while "snapshots" has snapshots enabled. When a request comes for the snapshots repository, webdav is using the metadata for the "internal" server which has snapshots disabled and refuses to download snapshots. 
> It's possible that if it downloaded snapshots they would be put on the wrong repository ("internal"), but I haven't verified this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-778) DefaultDavServerManager.createServer doesn't create server

Posted by "Carlos Costa e Silva (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Carlos Costa e Silva closed MRM-778.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1

Fixed with the introduction of Jackrabbit-webdav.

> DefaultDavServerManager.createServer doesn't create server
> ----------------------------------------------------------
>
>                 Key: MRM-778
>                 URL: http://jira.codehaus.org/browse/MRM-778
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.1
>            Reporter: Carlos Costa e Silva
>            Priority: Blocker
>             Fix For: 1.1
>
>         Attachments: ServerManager.zip
>
>
> In DefaultDavServerManager, the createServer method instead of creating a new server each time it's called is reusing the same server for all paths.
> The "DavServerComponent server" needs to be created each time createServer is called instead of being injected by plexus when the DavServerManager is created.
> This bug makes multiple repositories with different settings not work. 
> For example "internal" has snapshots disabled, while "snapshots" has snapshots enabled. When a request comes for the snapshots repository, webdav is using the metadata for the "internal" server which has snapshots disabled and refuses to download snapshots. 
> It's possible that if it downloaded snapshots they would be put on the wrong repository ("internal"), but I haven't verified this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MRM-778) DefaultDavServerManager.createServer doesn't create server

Posted by "Carlos Costa e Silva (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=130826#action_130826 ] 

carloscs edited comment on MRM-778 at 4/14/08 8:05 PM:
-------------------------------------------------------------------

Patch follows for this issue.

application.xml: remove injection of DavServerComponent to DavServerManager.

DavServerManager.createServer: add parameter ServletConfig config .

DefaultDavServerManager.createServer: add parameter ServletConfig config and fetch server from spring.

BasicWebDavServlet and MultiplexedWebDavServlet add config parameter to createServer call.


      was (Author: carloscs):
    Patch follows for this issue.

application.xml: remove injection of DavServerComponent to DavServerManager.

DavServerManager.createServer: add parameter ServletConfig config .

DefaultDavServerManager.createSerber: add parameter ServletConfig config and fetch server from spring.

BasicWebDavServlet and MultiplexedWebDavServlet add config parameter to createServer call.

  
> DefaultDavServerManager.createServer doesn't create server
> ----------------------------------------------------------
>
>                 Key: MRM-778
>                 URL: http://jira.codehaus.org/browse/MRM-778
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.1
>            Reporter: Carlos Costa e Silva
>            Priority: Blocker
>         Attachments: ServerManager.zip
>
>
> In DefaultDavServerManager, the createServer method instead of creating a new server each time it's called is reusing the same server for all paths.
> The "DavServerComponent server" needs to be created each time createServer is called instead of being injected by plexus when the DavServerManager is created.
> This bug makes multiple repositories with different settings not work. 
> For example "internal" has snapshots disabled, while "snapshots" has snapshots enabled. When a request comes for the snapshots repository, webdav is using the metadata for the "internal" server which has snapshots disabled and refuses to download snapshots. 
> It's possible that if it downloaded snapshots they would be put on the wrong repository ("internal"), but I haven't verified this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira