You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "David Crossley (JIRA)" <ji...@apache.org> on 2006/04/07 03:09:28 UTC
[jira] Created: (FOR-848) upgrade NoteTaking plugin to use current
Dispatcher
upgrade NoteTaking plugin to use current Dispatcher
---------------------------------------------------
Key: FOR-848
URL: http://issues.apache.org/jira/browse/FOR-848
Project: Forrest
Type: Bug
Components: Dispatcher (aka views), Plugin: internal.NoteTaking
Versions: 0.8-dev
Reporter: David Crossley
Fix For: 0.8-dev
The NoteTaking plugin is still using the old experimental Structurer plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-848) upgrade NoteTaking plugin to use current
Dispatcher
Posted by "Ross Gardler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-848?page=all ]
Ross Gardler updated FOR-848:
-----------------------------
Fix Version: (was: 0.8-dev)
> upgrade NoteTaking plugin to use current Dispatcher
> ---------------------------------------------------
>
> Key: FOR-848
> URL: http://issues.apache.org/jira/browse/FOR-848
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views), Plugin: internal.NoteTaking
> Versions: 0.8-dev
> Reporter: David Crossley
>
> The NoteTaking plugin is still using the old experimental Structurer plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Commented: (FOR-848) upgrade NoteTaking plugin to use current Dispatcher
Posted by David Crossley <cr...@apache.org>.
Ross Gardler wrote:
> Gav.... wrote:
> >>I am working on this and am making some progress.
> >>The plugin has now been converted to use current Dispatcher.
> >>I still need to get a 'notes' example working however.
> >
> >Rather than waffle on in Jira I'll extend this here.
>
> I see this is in the 0.8-dev roadmap. That is a mistake. No plugins
> issues should be in the 0.8-dev roadmap since they have their own
> release cycles. However, it does need fixing so I don't mean to
> discourage you.
I think that we might have pushed all that type of
Dispatcher-related issue onto the roadmap to ensure
that there is just one version of Dispatcher in the
0.8 release. The FOR-848 was intended to just fix their
configuration to not use the old "structurer" plugin, etc.
They could still have issues. Dispatcher is not the
default, so that doesn't matter.
> With respect to the fact that you cannot see a working example. I'm not
> up to date with the move to V3 so I'm afraid I cannot help much, you
> have done more work than I in that area.
>
> >Looking at http://issues.apache.org/jira/browse/FOR-739 I would have
> >thought
> >that this forrest.properties.xml file would work fine now, if I am
> >mistaken can someone advise where I am to put these properties now.
>
> I can confirm both that forrest.properties.xml is fully functional and
> the notes plugin worked perfectly well against V2. The problem must
> therefore be in the changes between V2 and V3 of the dispatcher.
>
> I can send you a working app offlist if you like (it's quite large since
> it contains all of shakespeares plays). Alternatively check out a
> version of Forrest that still has V2 in it and run the plugin under that.
Gav, if you would rather get on with something else,
then just create a new Jira issue for it.
-David
Re: [jira] Commented: (FOR-848) upgrade NoteTaking plugin to use
current Dispatcher
Posted by Ross Gardler <rg...@apache.org>.
Gav.... wrote:
>
>>-----Original Message-----
>>From: Gavin (JIRA) [mailto:jira@apache.org]
>>Sent: Saturday, 6 May 2006 8:36 PM
>>To: dev@forrest.apache.org
>>Subject: [jira] Commented: (FOR-848) upgrade NoteTaking plugin to use
>>current Dispatcher
>>
>> [ http://issues.apache.org/jira/browse/FOR-
>>848?page=comments#action_12378211 ]
>>
>>Gavin commented on FOR-848:
>>---------------------------
>>
>>I am working on this and am making some progress.
>>The plugin has now been converted to use current Dispatcher.
>>I still need to get a 'notes' example working however.
>
>
> Rather than waffle on in Jira I'll extend this here.
I see this is in the 0.8-dev roadmap. That is a mistake. No plugins
issues should be in the 0.8-dev roadmap since they have their own
release cycles. However, it does need fixing so I don't mean to
discourage you.
With respect to the fact that you cannot see a working example. I'm not
up to date with the move to V3 so I'm afraid I cannot help much, you
have done more work than I in that area.
> Looking at http://issues.apache.org/jira/browse/FOR-739 I would have thought
> that this forrest.properties.xml file would work fine now, if I am
> mistaken can someone advise where I am to put these properties now.
I can confirm both that forrest.properties.xml is fully functional and
the notes plugin worked perfectly well against V2. The problem must
therefore be in the changes between V2 and V3 of the dispatcher.
I can send you a working app offlist if you like (it's quite large since
it contains all of shakespeares plays). Alternatively check out a
version of Forrest that still has V2 in it and run the plugin under that.
> The sample for a notes.xml file states :-
...
> Does anyone have a actual code example as I am unsure how
> <path><to><page> is represented.
The <path><to><page> is quite simple (when you see it):
Suppose I write a note for /foo/bar/mypage.xml, the note snippet will be:
<foo>
<bar>
<mypage>
<notes>blah blah blah</notes>
</mypage>
</bar>
</foo>
Ross
RE: [jira] Commented: (FOR-848) upgrade NoteTaking plugin to use current Dispatcher
Posted by "Gav...." <br...@brightontown.com.au>.
> -----Original Message-----
> From: Gavin (JIRA) [mailto:jira@apache.org]
> Sent: Saturday, 6 May 2006 8:36 PM
> To: dev@forrest.apache.org
> Subject: [jira] Commented: (FOR-848) upgrade NoteTaking plugin to use
> current Dispatcher
>
> [ http://issues.apache.org/jira/browse/FOR-
> 848?page=comments#action_12378211 ]
>
> Gavin commented on FOR-848:
> ---------------------------
>
> I am working on this and am making some progress.
> The plugin has now been converted to use current Dispatcher.
> I still need to get a 'notes' example working however.
Rather than waffle on in Jira I'll extend this here.
The NoteTaking Plugin has now been upgraded to Dispatcher code
And works fine in that the sample site displays fine. However
I can not get the 'notes' themselves to work, without a
Previous working example of what it should be like I
Am flying blind a bit here.
To start with, there is no example notes.xml present in
/src/notes/ folder (the /src/notes/folder does not exist)
I am not surprised as I guess a first edit of a notes area
Would see the creation of this file, with amendments to
It thererafter.
But there is no 'notes' area appearing on the page for
Anywhere to edit in the first place.
The relevant code pieces are :-
In common.fv
------------------
<forrest:hook name="notes">
<forrest:contract name="content-noteTaking">
<forrest:property
name="content-noteTaking-srcDoc">#{$cocoon/parameters/getRequest}</forrest:p
roperty>
<forrest:property name="content-noteTaking-notes"><jx:import
uri="cocoon://noteTaking/do/getNotes/#{$cocoon/parameters/getRequest}"/></fo
rrest:property>
<forrest:property name="content-noteTaking-cols" value="60"/>
<forrest:property name="content-noteTaking-rows" value="10"/>
</forrest:contract>
</forrest:hook>
------------------
I am unsure whether :-
<forrest:property
name="content-noteTaking-srcDoc">#{$cocoon/parameters/getRequest}</forrest:p
roperty>
Is correct or not, can someone confirm ?
The output result of the above is <notes /> so no 60x10 box for
Writing any notes is created.
In forrest.properties.xml :-
------------------
<?xml version="1.0" encoding="UTF-8"?>
<properties>
<property name="noteTaking.repository.URL" value="src/notes/"/>
<property name="noteTaking.filename" value="notes.xml"/>
</properties>
------------------
Looking at http://issues.apache.org/jira/browse/FOR-739 I would have thought
that this forrest.properties.xml file would work fine now, if I am
mistaken can someone advise where I am to put these properties now.
The sample for a notes.xml file states :-
------------------
All notes are kept in a single notes file. This file has the following
structure:
<notes>
<path>
<to>
<page>
<pageName>
<notes>The notes</notes>
</pageName>
<anotherPage>
<notes>Some other notes</notes>
</anotherPage>
</page>
</to>
</path>
</notes>
------------------
Does anyone have a actual code example as I am unsure how
<path><to><page> is represented.
Like I say, plugin upgrade to Dispatcher is done, but still
Pretty useless without a working notes example, pointers
Greatly appreciated. The focus for getting this working
Is to clear another Issue from for-roadmap 0.8 out of
The way, I don't need it, but can envisage its
Usefulness.
Gav...
>
> > upgrade NoteTaking plugin to use current Dispatcher
> > ---------------------------------------------------
> >
> > Key: FOR-848
> > URL: http://issues.apache.org/jira/browse/FOR-848
> > Project: Forrest
> > Type: Bug
>
> > Components: Dispatcher (aka views), Plugin: internal.NoteTaking
> > Versions: 0.8-dev
> > Reporter: David Crossley
> > Fix For: 0.8-dev
>
> >
> > The NoteTaking plugin is still using the old experimental Structurer
> plugins.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
>
>
>
> --
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.1.392 / Virus Database: 268.5.5/333 - Release Date: 5/05/2006
[jira] Commented: (FOR-848) upgrade NoteTaking plugin to use
current Dispatcher
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-848?page=comments#action_12378211 ]
Gavin commented on FOR-848:
---------------------------
I am working on this and am making some progress.
The plugin has now been converted to use current Dispatcher.
I still need to get a 'notes' example working however.
> upgrade NoteTaking plugin to use current Dispatcher
> ---------------------------------------------------
>
> Key: FOR-848
> URL: http://issues.apache.org/jira/browse/FOR-848
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views), Plugin: internal.NoteTaking
> Versions: 0.8-dev
> Reporter: David Crossley
> Fix For: 0.8-dev
>
> The NoteTaking plugin is still using the old experimental Structurer plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (FOR-848) upgrade NoteTaking plugin to use current
Dispatcher
Posted by "Gavin (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-848?page=all ]
Gavin updated FOR-848:
----------------------
Attachment: notetaking_plugin.diff
Attached diff file upgrades plugin to dispatcher.
The actual 'notes' part of it does not work atm.
See http://marc.theaimsgroup.com/?l=forrest-dev&m=114692015816349&w=2 for why.
> upgrade NoteTaking plugin to use current Dispatcher
> ---------------------------------------------------
>
> Key: FOR-848
> URL: http://issues.apache.org/jira/browse/FOR-848
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views), Plugin: internal.NoteTaking
> Versions: 0.8-dev
> Reporter: David Crossley
> Attachments: notetaking_plugin.diff
>
> The NoteTaking plugin is still using the old experimental Structurer plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (FOR-848) upgrade NoteTaking plugin to use current
Dispatcher
Posted by "Thorsten Scherler (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/FOR-848?page=all ]
Thorsten Scherler closed FOR-848:
---------------------------------
Resolution: Fixed
Committed revision 418830.
Thanks Gavin for the patch.
> upgrade NoteTaking plugin to use current Dispatcher
> ---------------------------------------------------
>
> Key: FOR-848
> URL: http://issues.apache.org/jira/browse/FOR-848
> Project: Forrest
> Type: Bug
> Components: Dispatcher (aka views), Plugin: internal.NoteTaking
> Versions: 0.8-dev
> Reporter: David Crossley
> Attachments: notetaking_plugin.diff
>
> The NoteTaking plugin is still using the old experimental Structurer plugins.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira