[GitHub] [airflow] BasPH commented on a change in pull request #8991: All classes in backport providers are now importable in Airflow 1.10

[GitBox <gi...@apache.org>]

BasPH commented on a change in pull request #8991:
URL: https://github.com/apache/airflow/pull/8991#discussion_r429612732



##########
File path: airflow/providers/odbc/hooks/odbc.py
##########
@@ -24,7 +24,23 @@
 import pyodbc
 
 from airflow.hooks.dbapi_hook import DbApiHook
-from airflow.utils.helpers import merge_dicts
+
+
+# We do not import it from airflow.utils because merge_dicts is not available in Airflow 1.10
+# So this operator would not be backportable
+def merge_dicts(dict1, dict2):

Review comment:
       I understand this change comes from master to make things compatible, but think we should remove it entirely (in another PR). This is a one-liner in native Python: `{**dict1, **dict2}`, no need for a custom dict merge function.

##########
File path: backport_packages/import_all_provider_classes.py
##########
@@ -0,0 +1,97 @@
+#!/usr/bin/env python3
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import importlib
+import os
+import sys
+import traceback
+from inspect import isclass
+from typing import List
+
+
+def import_all_provider_classes(source_path: str,

Review comment:
       nice one!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org