You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/12/17 06:45:41 UTC

[GitHub] [incubator-mxnet] leezu opened a new pull request #17098: Disable OpenMP offloading support for 3rdparty/openmp

leezu opened a new pull request #17098: Disable OpenMP offloading support for 3rdparty/openmp
URL: https://github.com/apache/incubator-mxnet/pull/17098
 
 
   ## Description ##
   OpenMP offloading was introduced some time during the past two years and is
   enabled by default. With upgrading 3rdparty/openmp in
   #17012 it was unintentionally made part of the MXNet CMake build.
   
   But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP
   Offloading build is broken in our setting. Thus disable it.
   
   Due to bug in CMake < 3.13, this requires updating to CMake 3.13. See https://cmake.org/cmake/help/latest/policy/CMP0077.html
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [X] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [X] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [X] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] Disable OpenMP offloading support for 3rdparty/openmp in CMake build, which was enabled by mistake

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services