You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2015/03/03 12:26:58 UTC
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 3, 2015, 11:26 a.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Summary (updated)
-----------------
libprocess: Create IP and IPNetwork AF_INET abstraction.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description (updated)
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75351
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-05 17:07:20 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 5, 2015, 3:48 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 3:48 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75499
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-06 18:13:50 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On March 6, 2015, 6:38 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/src/process.cpp, line 837
> > <https://reviews.apache.org/r/29289/diff/24/?file=887418#file887418line837>
> >
> > Please do not remove any logging.
> >
> > ```
> > LOG(FATAL) << "Parsing LIBPROCESS_IP=" << value << " failed: " << ip.error();
> > ```
> >
> > `ip.isError()` is a boolean, are you going to print a boolean when the parsing fails?
sorry for that.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74860
-----------------------------------------------------------
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74860
-----------------------------------------------------------
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment121664>
Why change this? I thought the original code should just work fine because `hash_combine` will invoke `hash_value` for `IP`.
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122608>
Please follow the style guide for includes:
```
#include <boost/functional/hash.hpp>
#include <stout/ip.hpp>
```
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122609>
No need to use leading underscore for all parameters! In this case, it's not necessary.
3rdparty/libprocess/include/process/address.hpp
<https://reviews.apache.org/r/29289/#comment122610>
Let's not add any IPv6 impl. yet in this patch. Please remove them.
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29289/#comment122638>
Why do you want to pass in the family? Can you get the family from sockaddr_storage?
This changes the Socket API below which we should avoid if uncesssary.
3rdparty/libprocess/include/process/network.hpp
<https://reviews.apache.org/r/29289/#comment122641>
I don't think you need to initialize the sockaddr_storage here? As a result, you don't need to construct an IP.
3rdparty/libprocess/include/process/pid.hpp
<https://reviews.apache.org/r/29289/#comment122611>
Add a blank line above `#include <stout/ip.hpp>`
3rdparty/libprocess/include/process/socket.hpp
<https://reviews.apache.org/r/29289/#comment122643>
As I explained above, no need to do this API change!
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/29289/#comment122613>
Add a space before `TODO`.
3rdparty/libprocess/src/pid.cpp
<https://reviews.apache.org/r/29289/#comment122626>
As we discussed offline. This change is not necessary. Please revert.
3rdparty/libprocess/src/process.cpp
<https://reviews.apache.org/r/29289/#comment122646>
Please do not remove any logging.
```
LOG(FATAL) << "Parsing LIBPROCESS_IP=" << value << " failed: " << ip.error();
```
`ip.isError()` is a boolean, are you going to print a boolean when the parsing fails?
- Jie Yu
On March 6, 2015, 5:16 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 5:16 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75622
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On March 6, 2015, 10:56 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 6, 2015, 10:56 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 10:56 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 8:07 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 8:03 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 6, 2015, 5:16 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review75442
-----------------------------------------------------------
Bad patch!
Reviews applied: [31677]
Failed command: ./support/apply-review.sh -n -r 31677
Error:
2015-03-06 01:28:59 URL:https://reviews.apache.org/r/31677/diff/raw/ [1337/1337] -> "31677.patch" [1]
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp:350
error: 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On March 5, 2015, 7:38 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 7:38 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 5, 2015, 7:38 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Changes
-------
rebased
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 671aff6692be4ec49f7af4851a0511c178e58b45
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/
-----------------------------------------------------------
(Updated March 5, 2015, 3:48 p.m.)
Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
Bugs: MESOS-1919
https://issues.apache.org/jira/browse/MESOS-1919
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
Diff: https://reviews.apache.org/r/29289/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 29289: libprocess: Create IP and IPNetwork AF_INET
abstraction.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29289/#review74947
-----------------------------------------------------------
Patch looks great!
Reviews applied: [31470, 31471, 29288, 31677, 31472, 29290, 31473, 29289]
All tests passed.
- Mesos ReviewBot
On March 3, 2015, 11:26 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29289/
> -----------------------------------------------------------
>
> (Updated March 3, 2015, 11:26 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Dominic Hamon, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.
>
>
> Bugs: MESOS-1919
> https://issues.apache.org/jira/browse/MESOS-1919
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am e55147ae535b2b27271b69da3db7aff6cd202368
> 3rdparty/libprocess/include/process/address.hpp f5fb4dd2fdeaade36390c083bee6f2787df4b6d3
> 3rdparty/libprocess/include/process/network.hpp 7620278e4b2c376e37353325aa717fe54b819272
> 3rdparty/libprocess/include/process/pid.hpp 30c466c8defb45bbfaaf68611fb68285a89fea6e
> 3rdparty/libprocess/include/process/socket.hpp 2c4258775bd90f91f1922a3cf2bb4ddf5c334881
> 3rdparty/libprocess/src/http.cpp f9d9daf0bbde4286cb5b47cd121b7513d9199915
> 3rdparty/libprocess/src/pid.cpp d28a1541a10582c0ec42a2c26ee3bdb6683bb8bd
> 3rdparty/libprocess/src/poll_socket.cpp ec781a3ac0a245831c679826c97045fd3a2b4656
> 3rdparty/libprocess/src/process.cpp 6f9a0d290de6838c20d208266b670999186e1798
> 3rdparty/libprocess/src/socket.cpp 0e1cebb19e21c706b152d35a0b8722924c971a35
> 3rdparty/libprocess/src/tests/http_tests.cpp 0a00ae59fe999344eb05bee04ab3fb703a3265e7
> 3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618
>
> Diff: https://reviews.apache.org/r/29289/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>