You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/02 12:00:33 UTC
[GitHub] [cloudstack] rohityadavcloud opened a new pull request, #6942: ssvm: synchorise when adding iptables and routing rules
rohityadavcloud opened a new pull request, #6942:
URL: https://github.com/apache/cloudstack/pull/6942
Use synchronised in NfsSecondaryStorageResource when adding iptables and routing rules; try three times and check/log for error.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363689827
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363015136
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367347170
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1039309837
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2234,15 +2234,21 @@ public String allowOutgoingOnPrivate(String destCidr) {
command.add("-c");
command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p tcp -m state --state NEW -m tcp -j ACCEPT");
- String result = command.execute();
- if (result != null) {
- s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
- return "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ String msg = null;
+ for (int retry = 3; retry > 0; retry--) {
+ String result = command.execute();
Review Comment:
@rohityadavcloud
I wonder if the exit code should be checked instead of the output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615751
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2238,11 +2238,18 @@ public String allowOutgoingOnPrivate(String destCidr) {
if (result != null) {
s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
return "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ if (result != null) {
+ msg = "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ s_logger.warn(msg);
+ } else {
+ msg = null;
+ break;
+ }
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364569230
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1344465977
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367709751
<b>Trillian test result (tid-5693)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46208 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5693-kvm-centos7.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367305616
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367736796
<b>Trillian test result (tid-5699)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 46344 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5699-vmware-67u3.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1059260056
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
return null;
}
- public String allowOutgoingOnPrivate(String destCidr) {
+ public synchronized String allowOutgoingOnPrivate(String destCidr) {
Review Comment:
@rohityadavcloud could you add a javadoc with the description and background?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615955
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2242,7 +2242,7 @@ public String allowOutgoingOnPrivate(String destCidr) {
addRouteToInternalIpOrCidr(_localgw, _eth1ip, _eth1mask, destCidr);
- return null;
+ return msg;
Review Comment:
```suggestion
return null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1337017194
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6942 (QA-JID-4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1044585712
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2234,15 +2234,21 @@ public String allowOutgoingOnPrivate(String destCidr) {
command.add("-c");
command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p tcp -m state --state NEW -m tcp -j ACCEPT");
- String result = command.execute();
- if (result != null) {
- s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
- return "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ String msg = null;
+ for (int retry = 3; retry > 0; retry--) {
+ String result = command.execute();
Review Comment:
I think on error the result is non-empty which is what the code is earlier, I added just this retry-logic around it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364591489
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363671875
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367380337
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1065498870
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
return null;
}
- public String allowOutgoingOnPrivate(String destCidr) {
+ public synchronized String allowOutgoingOnPrivate(String destCidr) {
Review Comment:
Could not be reproduced (the bug), so the solution as well could not be verified. The customer has confirmed (by testing in their env) that the "synchronized" seems to solve the issue on their end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1344467040
@rohityadavcloud a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1044739740
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2234,15 +2234,21 @@ public String allowOutgoingOnPrivate(String destCidr) {
command.add("-c");
command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p tcp -m state --state NEW -m tcp -j ACCEPT");
- String result = command.execute();
- if (result != null) {
- s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
- return "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ String msg = null;
+ for (int retry = 3; retry > 0; retry--) {
+ String result = command.execute();
Review Comment:
@rohityadavcloud
understood, your code is good.
I just wondered if it works as you expected. Have you faced any issue with it ? if you know how to reproduce the issue, we could verify if it is fixed by your PR.
I did a small test with the iptables command . the output is always empty, exit code is 0 or 2.
1. iptables command fails
```
[root@mgmt1 ~]# output=$(bash -c 'iptables -I OUTPUT -o eth1 -d 300.300.300.300/24 -p tcp -m state --state NEW -m tcp -j ACCEPT')
iptables v1.4.21: host/network `300.300.300.300' not found
Try `iptables -h' or 'iptables --help' for more information.
[root@mgmt1 ~]# echo $?
2
[root@mgmt1 ~]# echo $output
[root@mgmt1 ~]#
```
2. iptables command succeeds
```
[root@mgmt1 ~]# output=$(bash -c 'iptables -I OUTPUT -o eth1 -d 100.100.100.100/24 -p tcp -m state --state NEW -m tcp -j ACCEPT')
[root@mgmt1 ~]# echo $?
0
[root@mgmt1 ~]# echo $output
[root@mgmt1 ~]#
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
shwstppr closed pull request #6942: ssvm: synchorise when adding iptables and routing rules
URL: https://github.com/apache/cloudstack/pull/6942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1365266114
@rohityadavcloud a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363761253
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6942?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6942](https://codecov.io/gh/apache/cloudstack/pull/6942?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (08a69bb) into [main](https://codecov.io/gh/apache/cloudstack/commit/3d8ea4f3b3ee1c009871e00d20ea03087cdc18a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d8ea4f) will **increase** coverage by `0.44%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6942 +/- ##
============================================
+ Coverage 10.87% 11.31% +0.44%
- Complexity 7118 7334 +216
============================================
Files 2485 2494 +9
Lines 245522 246787 +1265
Branches 38335 38533 +198
============================================
+ Hits 26701 27933 +1232
+ Misses 215550 215254 -296
- Partials 3271 3600 +329
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6942?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...va/com/cloud/upgrade/dao/DatabaseAccessObject.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYXRhYmFzZUFjY2Vzc09iamVjdC5qYXZh) | `0.00% <0.00%> (-97.50%)` | :arrow_down: |
| [...ain/java/com/cloud/upgrade/dao/DbUpgradeUtils.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYlVwZ3JhZGVVdGlscy5qYXZh) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade444to450.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDQ0dG80NTAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade453to460.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDUzdG80NjAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...java/com/cloud/upgrade/DatabaseUpgradeChecker.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0RhdGFiYXNlVXBncmFkZUNoZWNrZXIuamF2YQ==) | `0.00% <0.00%> (-46.67%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade431to440.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDMxdG80NDAuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade432to440.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDMydG80NDAuamF2YQ==) | `0.00% <0.00%> (-40.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/LegacyDbUpgrade.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9MZWdhY3lEYlVwZ3JhZGUuamF2YQ==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: |
| [.../com/cloud/storage/dao/StoragePoolTagsDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9TdG9yYWdlUG9vbFRhZ3NEYW9JbXBsLmphdmE=) | `12.90% <0.00%> (-32.26%)` | :arrow_down: |
| [...va/com/cloud/upgrade/DatabaseVersionHierarchy.java](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL0RhdGFiYXNlVmVyc2lvbkhpZXJhcmNoeS5qYXZh) | `56.81% <0.00%> (-29.55%)` | :arrow_down: |
| ... and [158 more](https://codecov.io/gh/apache/cloudstack/pull/6942/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364586598
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363671872
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363524993
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1337132144
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/6942 (QA-JID-7)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367736141
<b>Trillian test result (tid-5700)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46081 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5700-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 3648.34 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.08 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 67.60 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1065451525
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2225,7 +2225,7 @@ private String deleteLocalFile(String fullPath) {
return null;
}
- public String allowOutgoingOnPrivate(String destCidr) {
+ public synchronized String allowOutgoingOnPrivate(String destCidr) {
Review Comment:
```suggestion
/**
* allow *only one* setting of an outgoing destination at a time
*
* @destCidr the destination network that will be allowed for outgoing traffic.
* @return any error message that might be helpful or <null> on success or when called anywhere but in the router VM.
*/
public synchronized String allowOutgoingOnPrivate(String destCidr) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377235994
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #6942: ssvm: synchorise when adding iptables and routing rules
URL: https://github.com/apache/cloudstack/pull/6942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363689986
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364562703
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364318138
<b>Trillian test result (tid-5626)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45715 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5626-kvm-centos7.zip
Smoke tests completed. 104 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.19 | test_diagnostics.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 563.50 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364586693
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377333190
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377588241
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1378235463
<b>Trillian test result (tid-5791)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5791-xenserver-71.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 309.26 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1337123695
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363014553
This is extremely rare case, reverted other changes except the synchornised fix.
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363678057
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6942)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1363526105
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367305325
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367359127
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6942)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367380474
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367441606
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377587171
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1336494017
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335181942
thx @rohityadavcloud
For the record: this has been impossible to reproduce in my test env (based on the instructions given by the relevant third party) - the problem is when doing multiple volume snapshots in multiple clusters, at the exact same time - ACS tries to add iptables rule inside SSVM to allow outgoing traffic (to vCenter I think) - and since there are multiple concurrent attempts to add iptable rule - some of those would fail (since iptable has an internal locking mechanism where it creates a lock while an rule is being added, so another rule/thread can not run) - so some of the snapshot jobs would fail as a consequence of not being able to add iptable rule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1336484378
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1336484289
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335137621
This is hard to test/reproduce. I think this code is called by multiple threads which can cause xlock/iptables locking issue where the command fails and when it does ip routing rules aren't added. By putting synchronized on the method and logging/trying three times seem to be working in a rare-case env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377235120
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1377350815
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6942)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1378284626
<b>Trillian test result (tid-5793)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45331 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5793-kvm-centos7.zip
Smoke tests completed. 106 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3620.74 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.06 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.05 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 67.48 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1378316878
<b>Trillian test result (tid-5792)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 48426 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5792-vmware-67u3.zip
Smoke tests completed. 107 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367442211
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335138328
cc @andrijapanicsb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1335188335
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6942)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6942&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6942&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6942&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1337123928
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1345100866
<b>Trillian test result (tid-5446)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 43743 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5446-kvm-centos7.zip
Smoke tests completed. 102 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_05_stop_ssvm | `Error` | 937.29 | test_ssvm.py
test_07_reboot_ssvm | `Error` | 909.14 | test_ssvm.py
test_09_reboot_ssvm_forced | `Error` | 948.02 | test_ssvm.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 599.08 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364562814
@rohityadavcloud a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367739218
<b>Trillian test result (tid-5698)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47158 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6942-t5698-xenserver-71.zip
Smoke tests completed. 104 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_create_pvlan_network | `Error` | 0.04 | test_pvlan.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 170.88 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1614.20 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1367751614
@andrijapanicsb have you verified that this solves the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1365265298
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on a diff in pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on code in PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#discussion_r1055615111
##########
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java:
##########
@@ -2234,15 +2234,21 @@ public String allowOutgoingOnPrivate(String destCidr) {
command.add("-c");
command.add("iptables -I OUTPUT -o " + intf + " -d " + destCidr + " -p tcp -m state --state NEW -m tcp -j ACCEPT");
- String result = command.execute();
- if (result != null) {
- s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
- return "Error in allowing outgoing to " + destCidr + ", err=" + result;
+ String msg = null;
+ for (int retry = 3; retry > 0; retry--) {
+ String result = command.execute();
Review Comment:
```suggestion
String result = command.execute();
if (result != null) {
s_logger.warn("Error in allowing outgoing to " + destCidr + ", err=" + result);
return "Error in allowing outgoing to " + destCidr + ", err=" + result;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942#issuecomment-1364562668
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6942: ssvm: synchorise when adding iptables and routing rules
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6942:
URL: https://github.com/apache/cloudstack/pull/6942
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org