[jira] [Commented] (FLINK-7208) Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16706042#comment-16706042 ] 

ASF GitHub Bot commented on FLINK-7208:
---------------------------------------

walterddr commented on a change in pull request #7201: [FLINK-7208] [table] Optimize Min/MaxWithRetractAggFunction with DataView
URL: https://github.com/apache/flink/pull/7201#discussion_r238080462
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/aggfunctions/MaxAggFunctionWithRetract.scala
 ##########
 @@ -18,19 +18,20 @@
 package org.apache.flink.table.functions.aggfunctions
 
 import java.math.BigDecimal
-import java.util.{HashMap => JHashMap}
-import java.lang.{Iterable => JIterable}
+import java.lang.{Iterable => JIterable, Long => JLong}
 import java.sql.{Date, Time, Timestamp}
 
-import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation}
-import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
-import org.apache.flink.api.java.typeutils.{MapTypeInfo, TupleTypeInfo}
-import org.apache.flink.table.api.Types
+import org.apache.flink.api.common.typeinfo.{BasicTypeInfo, TypeInformation, Types}
+import org.apache.flink.table.api.dataview.MapView
 import org.apache.flink.table.functions.aggfunctions.Ordering._
 import org.apache.flink.table.functions.AggregateFunction
 
 /** The initial accumulator for Max with retraction aggregate function */
-class MaxWithRetractAccumulator[T] extends JTuple2[T, JHashMap[T, Long]]
+class MaxWithRetractAccumulator[T] {
 
 Review comment:
   I believe you need to add Test/ITCase w.r.p.t state backend if you are using DataViews since they went through different code path when configuring in-mem vs. rocksdb. see: https://github.com/apache/flink/pull/5472/files#diff-a7480859f8f621cf704c5a254a4b1a6dR160

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView
> -------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-7208
>                 URL: https://issues.apache.org/jira/browse/FLINK-7208
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: kaibo.zhou
>            Assignee: Dian Fu
>            Priority: Major
>              Labels: pull-request-available
>
> Refactor build-in agg(MaxWithRetractAccumulator and MinWithRetractAccumulator) using the DataView.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)