[GitHub] [spark] ever4Kenny commented on a diff in pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL

["ever4Kenny (via GitHub)" <gi...@apache.org>]

ever4Kenny commented on code in PR #34492:
URL: https://github.com/apache/spark/pull/34492#discussion_r1283027408


##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4:
##########
@@ -252,6 +252,8 @@ statement
         '(' columns=multipartIdentifierPropertyList ')'
         (OPTIONS options=propertyList)?                                #createIndex
     | DROP INDEX (IF EXISTS)? identifier ON TABLE? multipartIdentifier #dropIndex
+    | CREATE TEMPORARY MACRO IDENTIFIER '(' colTypeList ')'

Review Comment:
   should be:
   "| CREATE TEMPORARY MACRO IDENTIFIER '(' colTypeList? ')'"
   to support no arg macro.
   The colTypeList is optional.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org