You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by Kevin Minder <ke...@oracle.com> on 2016/06/28 14:45:02 UTC

Re: Code Quality Improvements for knox

Hi Artyom,
This sounds very interesting.  A few things:
1) Please continue this discussion on dev@knox.apache.org.  I've CCed my response there.
2) Please plan on following the contribution processes [1] as Apache doesn't really support pull requests yet.
Thanks!
Kevin.
[1] https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process <https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process>

> On Jun 28, 2016, at 4:42 AM, artyom.melnikov@devfactory.com wrote:
> 
> Hello,
> 
> I'd like to send you some pull requests to improve the maintainability of knox.
> 
> My company - DevFactory - is sponsoring me to identify and fix code quality issues and improve unit test coverage in open source projects. DevFactory is obsessed with code quality and is providing its commercially available code quality improvement service for free to qualified open-source projects.
> 
> If you are interested, please let me know and we will add it to our pipeline. Our first step will be to utilize tools like PMD, FindBugs and Sonar to identify the most important issues to fix. Once we fix them, we'll follow up with some pull requests.
> 
> Thanks,
> Artyom Melnikov
> 


Re: Code Quality Improvements for knox

Posted by larry mccay <lm...@apache.org>.
+1 for engaging dev@ and patches rather than pull requests. This sounds
like a great thing to focus on and drive quality and maintainability higher!
On Jun 28, 2016 7:45 AM, "Kevin Minder" <ke...@oracle.com> wrote:

> Hi Artyom,
> This sounds very interesting.  A few things:
> 1) Please continue this discussion on dev@knox.apache.org.  I've CCed my
> response there.
> 2) Please plan on following the contribution processes [1] as Apache
> doesn't really support pull requests yet.
> Thanks!
> Kevin.
> [1] https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process
> <https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process>
>
> > On Jun 28, 2016, at 4:42 AM, artyom.melnikov@devfactory.com wrote:
> >
> > Hello,
> >
> > I'd like to send you some pull requests to improve the maintainability
> of knox.
> >
> > My company - DevFactory - is sponsoring me to identify and fix code
> quality issues and improve unit test coverage in open source projects.
> DevFactory is obsessed with code quality and is providing its commercially
> available code quality improvement service for free to qualified
> open-source projects.
> >
> > If you are interested, please let me know and we will add it to our
> pipeline. Our first step will be to utilize tools like PMD, FindBugs and
> Sonar to identify the most important issues to fix. Once we fix them, we'll
> follow up with some pull requests.
> >
> > Thanks,
> > Artyom Melnikov
> >
>
>