You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "chibenwa (via GitHub)" <gi...@apache.org> on 2024/06/04 15:16:48 UTC
[PR] [IMPROVEMENT] Configure fastview projection miss threshold [james-project]
chibenwa opened a new pull request, #2276:
URL: https://github.com/apache/james-project/pull/2276
We observe some warning from perfectly well running systems. This threshold is hard coded, a bit of liberty can be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] Configure fastview projection miss threshold [james-project]
Posted by "quantranhong1999 (via GitHub)" <gi...@apache.org>.
quantranhong1999 commented on code in PR #2276:
URL: https://github.com/apache/james-project/pull/2276#discussion_r1626868049
##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/projections/MessageFastViewProjectionHealthCheck.java:
##########
@@ -35,7 +37,9 @@
public class MessageFastViewProjectionHealthCheck implements HealthCheck {
private static final ComponentName COMPONENT_NAME = new ComponentName("MessageFastViewProjection");
- private static final double MAXIMUM_MISS_PERCENTAGE_ACCEPTED = 10;
+ private static final double MAXIMUM_MISS_PERCENTAGE_ACCEPTED = Optional.ofNullable(System.getProperty("james.jmap.fastview.projection.max.miss.percentage.accepted", null))
Review Comment:
Should we document this in `jvm.adoc`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] Configure fastview projection miss threshold [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2276:
URL: https://github.com/apache/james-project/pull/2276#discussion_r1627162629
##########
server/data/data-jmap/src/main/java/org/apache/james/jmap/api/projections/MessageFastViewProjectionHealthCheck.java:
##########
@@ -35,7 +37,9 @@
public class MessageFastViewProjectionHealthCheck implements HealthCheck {
private static final ComponentName COMPONENT_NAME = new ComponentName("MessageFastViewProjection");
- private static final double MAXIMUM_MISS_PERCENTAGE_ACCEPTED = 10;
+ private static final double MAXIMUM_MISS_PERCENTAGE_ACCEPTED = Optional.ofNullable(System.getProperty("james.jmap.fastview.projection.max.miss.percentage.accepted", null))
Review Comment:
IMO this is niche...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] Configure fastview projection miss threshold [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa merged PR #2276:
URL: https://github.com/apache/james-project/pull/2276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] [IMPROVEMENT] Configure fastview projection miss threshold [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2276:
URL: https://github.com/apache/james-project/pull/2276#issuecomment-2153736714
Merge or not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org