[jira] [Work logged] (GOBBLIN-1497) Reduce the number of calls to create FlowSpecs and configToProperties

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1497?focusedWorklogId=628067&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628067 ]

ASF GitHub Bot logged work on GOBBLIN-1497:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jul/21 23:38
            Start Date: 26/Jul/21 23:38
    Worklog Time Spent: 10m 
      Work Description: Will-Lo opened a new pull request #3340:
URL: https://github.com/apache/gobblin/pull/3340


   … and configToProperties/vice versa
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1497
   
   
   ### Description
   - [ ] Here are some details about my PR, including screenshots (if applicable):
   
   FlowSpecs contain both configs and property fields that duplicate the same key/value information, however there are slight differences with properties being mutable, configs being type-safe, and legacy code being compatible with properties but not configs.
   
   As such, FlowSpec creation and configToProperties are memory expensive operations at scale, and we should aim to minimize them as much as possible.
   
   ### Tests
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 628067)
    Remaining Estimate: 0h
            Time Spent: 10m

> Reduce the number of calls to create FlowSpecs and configToProperties
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-1497
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1497
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> FlowSpecs contain both configs and property fields that duplicate the same key/value information, however there are slight differences with properties being mutable, configs being type-safe, and legacy code being compatible with properties but not configs.
> As such, FlowSpec creation and configToProperties are memory expensive operations at scale, and we should aim to minimize them as much as possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)