You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2014/12/18 23:40:41 UTC
Review Request 29219: Added Network Isolator flags to
configuration.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/
-----------------------------------------------------------
Review request for mesos, Till Toenshoff and Timothy Chen.
Repository: mesos-git
Description
-------
These flags are visible only when configured with --with-network-isolator flag.
Diffs
-----
docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
Diff: https://reviews.apache.org/r/29219/diff/
Testing
-------
Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
Thanks,
Kapil Arya
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65551
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On Dec. 18, 2014, 2:40 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 2:40 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65579
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29227, 29219]
All tests passed.
- Mesos ReviewBot
On Dec. 19, 2014, 12:56 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 12:56 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65689
-----------------------------------------------------------
Ship it!
docs/configuration.md
<https://reviews.apache.org/r/29219/#comment108900>
Is it common to abbreviate "have" when it is being used in written english?
- Till Toenshoff
On Dec. 19, 2014, 12:56 a.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 12:56 a.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65698
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29227, 29219]
All tests passed.
- Mesos ReviewBot
On Dec. 19, 2014, 10:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2014, 10:02 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/
-----------------------------------------------------------
(Updated Dec. 19, 2014, 5:02 p.m.)
Review request for mesos, Till Toenshoff and Timothy Chen.
Changes
-------
Addressed Till's comments.
Repository: mesos-git
Description
-------
These flags are visible only when configured with --with-network-isolator flag.
Diffs (updated)
-----
docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
Diff: https://reviews.apache.org/r/29219/diff/
Testing
-------
Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
Thanks,
Kapil Arya
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 7:56 p.m.)
Review request for mesos, Till Toenshoff and Timothy Chen.
Changes
-------
Updated description for max_executors_per_slave flag for master.
Repository: mesos-git
Description
-------
These flags are visible only when configured with --with-network-isolator flag.
Diffs (updated)
-----
docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
Diff: https://reviews.apache.org/r/29219/diff/
Testing
-------
Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
Thanks,
Kapil Arya
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65560
-----------------------------------------------------------
Patch looks great!
Reviews applied: [29219]
All tests passed.
- Mesos ReviewBot
On Dec. 18, 2014, 11:04 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Dec. 18, 2014, 6:33 p.m., Ben Mahler wrote:
> > docs/configuration.md, line 571
> > <https://reviews.apache.org/r/29219/diff/2/?file=796673#file796673line571>
> >
> > Thanks Kapil!
> >
> > Would love to see a mention of why one would use this flag (although such a note likely belongs in the flags.hpp file as well), especially on the network monitoring page: http://mesos.apache.org/documentation/latest/network-monitoring/
> >
> > We introduced this because the network monitoring / isolation technique imposes an implicit resource acquisition on each executor (# ephemeral ports), as a result you can only run a certain number of executors on each slave.
> >
> > This flag was added as a hack to avoid frameworks getting offers when we've allocated all of the ephemeral port range on the slave.
> >
> > Feel free to make such changes separately. :)
Done. I have created a separate RR (https://reviews.apache.org/r/29227/) to update flags.hpp. The wording is mostly yours :-).
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65562
-----------------------------------------------------------
On Dec. 18, 2014, 7:56 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 7:56 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/#review65562
-----------------------------------------------------------
docs/configuration.md
<https://reviews.apache.org/r/29219/#comment108788>
Thanks Kapil!
Would love to see a mention of why one would use this flag (although such a note likely belongs in the flags.hpp file as well), especially on the network monitoring page: http://mesos.apache.org/documentation/latest/network-monitoring/
We introduced this because the network monitoring / isolation technique imposes an implicit resource acquisition on each executor (# ephemeral ports), as a result you can only run a certain number of executors on each slave.
This flag was added as a hack to avoid frameworks getting offers when we've allocated all of the ephemeral port range on the slave.
Feel free to make such changes separately. :)
- Ben Mahler
On Dec. 18, 2014, 11:04 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29219/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2014, 11:04 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Timothy Chen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> These flags are visible only when configured with --with-network-isolator flag.
>
>
> Diffs
> -----
>
> docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
>
> Diff: https://reviews.apache.org/r/29219/diff/
>
>
> Testing
> -------
>
> Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 29219: Added Network Isolator flags to
configuration.md.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29219/
-----------------------------------------------------------
(Updated Dec. 18, 2014, 6:04 p.m.)
Review request for mesos, Till Toenshoff and Timothy Chen.
Changes
-------
Accidentally placed the slave flags under configuration header; fixed now.
Repository: mesos-git
Description
-------
These flags are visible only when configured with --with-network-isolator flag.
Diffs (updated)
-----
docs/configuration.md 069edebad3b695f106885928af28a936a91d11fa
Diff: https://reviews.apache.org/r/29219/diff/
Testing
-------
Checked on github at https://github.com/karya0/mesos/blob/hooks/docs/configuration.md
Thanks,
Kapil Arya