[GitHub] NielsZeilemaker commented on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler

[GitBox <gi...@apache.org>]

NielsZeilemaker commented on issue #4283: [AIRFLOW-3450] Remove unnecessary sigint handler
URL: https://github.com/apache/incubator-airflow/pull/4283#issuecomment-446640912
 
 
   @fokko in the case of Cloud Composer it is indeed the health check failing and hence a docker sends a sigterm. The actual exception which is in this case being propagated is the SystemExit exception being thrown by the sys.exit(0).
   
   It is a bit confusing, as the sigint_handler will be called on the main_thread and intermixed with other code. So the stacktrace isn't really a logical sequence of events anymore.
   
   Catching the sigterm and attempting a nice shutdown seems like a good idea, but I don't know if the current sys.exit(0) is the best implementation. Maybe setting a flag somewhere is a better option. 
   
   Catching the sigint (which could be a ctrl+c) is also good idea, as otherwise the scheduler will probably not respond to ctrl+c anymore. 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services