[jira] [Issue Comment Deleted] (HIVE-11652) Avoid expensive call to removeAll in DefaultGraphWalker

["Jesus Camacho Rodriguez (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-11652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesus Camacho Rodriguez updated HIVE-11652:
-------------------------------------------
    Comment: was deleted

(was: PS. I have just checked the _getChildren_ method in _ASTNode_: it creates a copy of the list of the original children of the AST node. It might be possible to return the list itself for the walker, thus preventing the copy of the list, which is expensive.

Cc [~dhiraj.kumar])

> Avoid expensive call to removeAll in DefaultGraphWalker
> -------------------------------------------------------
>
>                 Key: HIVE-11652
>                 URL: https://issues.apache.org/jira/browse/HIVE-11652
>             Project: Hive
>          Issue Type: Bug
>          Components: Logical Optimizer, Physical Optimizer
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Jesus Camacho Rodriguez
>            Assignee: Jesus Camacho Rodriguez
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11652.01.patch, HIVE-11652.02.patch, HIVE-11652.patch
>
>
> When the plan is too large, the removeAll call in DefaultGraphWalker (line 140) will take very long as it will have to go through the list looking for each of the nodes. We try to get rid of this call by rewriting the logic in the walker.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)