You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/04/30 07:16:45 UTC
[GitHub] [ozone] adoroszlai opened a new pull request, #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types
adoroszlai opened a new pull request, #3370:
URL: https://github.com/apache/ozone/pull/3370
## What changes were proposed in this pull request?
Some S3 tests are independent of the bucket type parameter. Currently these are run for regular bucket, link, encrypted bucket and EC bucket. Save some time by running only once per environment (secure/unsecure).
https://issues.apache.org/jira/browse/HDDS-6675
## How was this patch tested?
Verified that tagged tests are run only once, e.g.:
https://github.com/adoroszlai/hadoop-ozone/runs/6236210729#step:5:344
https://github.com/adoroszlai/hadoop-ozone/runs/6236210729#step:5:463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel commented on a diff in pull request #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types
Posted by GitBox <gi...@apache.org>.
sodonnel commented on code in PR #3370:
URL: https://github.com/apache/ozone/pull/3370#discussion_r865726627
##########
hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh:
##########
@@ -43,8 +43,11 @@ for scheme in ofs o3fs; do
done
done
+exclude=""
for bucket in encrypted link generated; do
- execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} s3
+ execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} ${exclude} s3
+ # some tests are independent of the bucket type, only need to be run once
+ exclude="--exclude no-bucket-type"
Review Comment:
This `--exclude` - is this just a parameter that the `robot` command understands? We pass this through and it then excludes any tests with the tag no-bucket-type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on pull request #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on PR #3370:
URL: https://github.com/apache/ozone/pull/3370#issuecomment-1120923376
Thanks @sodonnel for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a diff in pull request #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on code in PR #3370:
URL: https://github.com/apache/ozone/pull/3370#discussion_r865753342
##########
hadoop-ozone/dist/src/main/compose/ozonesecure/test.sh:
##########
@@ -43,8 +43,11 @@ for scheme in ofs o3fs; do
done
done
+exclude=""
for bucket in encrypted link generated; do
- execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} s3
+ execute_robot_test s3g -v BUCKET:${bucket} -N s3-${bucket} ${exclude} s3
+ # some tests are independent of the bucket type, only need to be run once
+ exclude="--exclude no-bucket-type"
Review Comment:
Exactly. I learned this from @smengcl in #3174.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai merged pull request #3370: HDDS-6675. Avoid repeating some S3 tests for different bucket types
Posted by GitBox <gi...@apache.org>.
adoroszlai merged PR #3370:
URL: https://github.com/apache/ozone/pull/3370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org